Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image_name and app_id are redundant #94

Merged
merged 1 commit into from
Sep 6, 2024
Merged

image_name and app_id are redundant #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Minimal/app_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-minimal-example
app_id: edge-minimal-example
framework: generic
app_id: null
app_version: 1.2.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Minimal/ci/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions Panel/app_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-panel-example
app_id: edge-panel-example
framework: panel
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Panel/ci/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions Plotly Dash/app_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-plotly-dash-example
app_id: edge-plotly-dash-example
framework: plotly-dash
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Plotly Dash/ci/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions React/app_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-react-example
app_id: edge-react-example
framework: react
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions React/ci/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -91,7 +91,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
3 changes: 1 addition & 2 deletions Streamlit/app_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
image_name: edge-streamlit-example
app_id: edge-streamlit-example
framework: streamlit
app_id: null
app_version: 1.3.0
python_version: 3.8
repository: quay.io
Expand Down
4 changes: 2 additions & 2 deletions Streamlit/ci/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _bundle_image(config: dict) -> str:
"""
return "/".join([config["repository"],
config["organisation"],
config["image_name"]])
config["app_id"]])


@click.group()
Expand Down Expand Up @@ -86,7 +86,7 @@ def run(config, bundle_image, verbose):

# Configuration details
bundle_image = bundle_image or _bundle_image(config)
container_name = config["image_name"]
container_name = config["app_id"]
version = config["app_version"]

# Get values from the dev settings file (API tokens for testing, etc.)
Expand Down
Loading