Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPython kernel-related cleanup #188

Merged
merged 42 commits into from
Sep 13, 2019
Merged

Fix IPython kernel-related cleanup #188

merged 42 commits into from
Sep 13, 2019

Commits on Sep 5, 2019

  1. First steps towards making IPKernelApp disposable.

    @mdickinson
    mdickinson committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    515aaf1 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. More progress towards ipykernel cleanup.

    @mdickinson
    mdickinson committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    504a23c View commit details
    Browse the repository at this point in the history

  2. More cleanup

    @mdickinson
    mdickinson committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    b48af73 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. More cleanup

    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    96836b1 View commit details
    Browse the repository at this point in the history

  2. No more leaked objects

    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    cbd12f7 View commit details
    Browse the repository at this point in the history

  3. Fix uncollectable garbage under Python 2.

    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    5737c0f View commit details
    Browse the repository at this point in the history

  4. Atexit fixes; attempted heartbeat fix (needs changes to the heartbeat… 

    … code).
    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    7e82617 View commit details
    Browse the repository at this point in the history

  5. Custom heartbeat code

    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    dfef826 View commit details
    Browse the repository at this point in the history

  6. Fix trait definition with hard-coded type.

    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    34766d0 View commit details
    Browse the repository at this point in the history

  7. Add reminder to subclass Heartbeat so that we don't have to redeclare… 

    … the trait.
    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    cefdd39 View commit details
    Browse the repository at this point in the history

  8. Cleanup of more globals.

    @mdickinson
    mdickinson committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    eb202c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Move the kernel application into its own module.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    d73c516 View commit details
    Browse the repository at this point in the history

  2. Tidy up heartbeat code; update comments.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    52dcd00 View commit details
    Browse the repository at this point in the history

  3. Comment indicating when it's safe to remove this workaround.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    bc67ca5 View commit details
    Browse the repository at this point in the history

  4. Fix docstring.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    9853cc4 View commit details
    Browse the repository at this point in the history

  5. Remove some unnecessary bits; move some machinery from internal_ipker… 

    …nel to kernelapp
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    af8b4d8 View commit details
    Browse the repository at this point in the history

  6. Move some more of the shutdown / cleanup code to the IPKernelApp; rem… 

    …ove some unnecessary cleanup
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    d9b9685 View commit details
    Browse the repository at this point in the history

  7. More cleanup; but we're now leaking a shell on Python 3 and failing o… 

    …n Python 2.
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    7ca5721 View commit details
    Browse the repository at this point in the history

  8. Fix use of logging.hasHandlers on Python 2.7; move IPython.utils.io.s… 

    …tdout caching to init_kernel.
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    52a021b View commit details
    Browse the repository at this point in the history

  9. Final(?) cleanups on internal_ipkernel.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    5b385fd View commit details
    Browse the repository at this point in the history

  10. Tweaks: remove outdated comment; fix grammar, spacing

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    cc1beae View commit details
    Browse the repository at this point in the history

  11. Add tests.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    f30bff8 View commit details
    Browse the repository at this point in the history

  12. Add test for atexit handlers.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    a641613 View commit details
    Browse the repository at this point in the history

  13. Expand comment for test_no_new_atexit_handlers to suggest strategies … 

    …on test failure.
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    cf83351 View commit details
    Browse the repository at this point in the history

  14. Add test for restoration of __main__ in sys.modules

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    23e40ce View commit details
    Browse the repository at this point in the history

  15. Add missing Popen.wait() call to avoid 'ResourceWarning' messages.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    be2533e View commit details
    Browse the repository at this point in the history

  16. Finish cleanup of kernelapp.py

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    7e6d96d View commit details
    Browse the repository at this point in the history

  17. Fold in raw_print and raw_print_err overrides

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    fb33888 View commit details
    Browse the repository at this point in the history

  18. Add tests for the raw_print and raw_print_err overrides.

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    65c37ab View commit details
    Browse the repository at this point in the history

  19. Tests to ensure that the globals that *we're* messing with are restor… 

    …ed properly.
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    302a0f7 View commit details
    Browse the repository at this point in the history

  20. Allow a few more zmq Sockets to be cleaned up without the aid of the … 

    …cyclic gc.
    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    ae56555 View commit details
    Browse the repository at this point in the history

  21. Clarify use of ==

    @mdickinson
    mdickinson committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    306de81 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Updates from review

    @mdickinson
    mdickinson committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    2ea7c3a View commit details
    Browse the repository at this point in the history

  2. Remove an unnecessary close call; fix a typo in a docstring.

    @mdickinson
    mdickinson committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    c894fad View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. Merge remote-tracking branch 'origin/master' into fix/ipkernel-shutdown

    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    535fc1b View commit details
    Browse the repository at this point in the history

  2. Don't delete sockets; some of the newer traitlets subclasses don't al… 

    …low this.
    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    be444ce View commit details
    Browse the repository at this point in the history

  3. Rename shutdown to close, remove atexit handler, terminate context.

    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    c431734 View commit details
    Browse the repository at this point in the history

  4. Override log_connection_info.

    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    2ae39d8 View commit details
    Browse the repository at this point in the history

  5. Now that we're overriding log_connection_info, no need to change the … 

    …ctrl_c message.
    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    54bda86 View commit details
    Browse the repository at this point in the history

  6. Remove all the machinery for monkey-patching raw_print, raw_print_err… 

    … and ctrl_c_message.
    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    b6682ba View commit details
    Browse the repository at this point in the history

  7. Style: suppress flake8 long line warning

    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    fa6a89c View commit details
    Browse the repository at this point in the history

  8. Also close the heartbeat socket in the case of unexpected errors.

    @mdickinson
    mdickinson committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    ab5b258 View commit details
    Browse the repository at this point in the history