Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button and Slider Widgets #844

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

amalss18
Copy link
Contributor

This will allow the user to add a slider, button to the scene and associate callbacks with these widgets.

@codecov-io
Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #844 into master will decrease coverage by 0.09%.
The diff coverage is 39%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #844     +/-   ##
=========================================
- Coverage   50.85%   50.76%   -0.1%     
=========================================
  Files         263      265      +2     
  Lines       23846    24046    +200     
  Branches     3252     3270     +18     
=========================================
+ Hits        12128    12206     +78     
- Misses      10931    11053    +122     
  Partials      787      787
Impacted Files Coverage Δ
mayavi/mlab.py 81.25% <100%> (+1.25%) ⬆️
mayavi/sources/widget_source.py 27.58% <27.58%> (ø)
mayavi/tools/widgets.py 40.58% <40.58%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa81934...0361f5b. Read the comment docs.


def _scene_changed(self, old, new):
if self._actors_added:
old.remove_wdigets(self.widgets)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, and the fact that this wasn't caught suggests no tests, can you please add a simple test so this is exercised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants