Skip to content

Commit

Permalink
CI changes for Ubuntu 22.04 (#1186)
Browse files Browse the repository at this point in the history
This PR fixes CI for Ubuntu 22.04 so that it is back into a working state. To this end it:

- updates the Qt debian packages
- removes the use of GabrielBB/xvfb-action@v1 (xvfb is in the default 22.04 image)
- removes linux/wx tests as we don't have a compatible wxpython wheel/egg for ubuntu 22.04/wxPython 4.0
  • Loading branch information
corranwebster committed Dec 19, 2022
1 parent ff6fa40 commit 9fc3bbc
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 10 deletions.
20 changes: 15 additions & 5 deletions .github/workflows/ets-from-source.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
toolkit: ['wx', 'pyqt5', 'pyside2']
exclude:
- os: ubuntu-latest
toolkit: 'wx'
runs-on: ${{ matrix.os }}
env:
# Set root directory, mainly for Windows, so that the EDM Python
Expand All @@ -30,14 +33,19 @@ jobs:
- name: Install Qt dependencies for Linux
run: |
sudo apt-get update
sudo apt-get install qt5-default
sudo apt-get install qtbase5-dev
sudo apt-get install qtchooser
sudo apt-get install qt5-qmake
sudo apt-get install qtbase5-dev-tools
sudo apt-get install libegl1
sudo apt-get install libxkbcommon-x11-0
sudo apt-get install libxcb-icccm4
sudo apt-get install libxcb-image0
sudo apt-get install libxcb-keysyms1
sudo apt-get install libxcb-randr0
sudo apt-get install libxcb-render-util0
sudo apt-get install libxcb-xinerama0
sudo apt-get install libxcb-shape0
sudo apt-get install pulseaudio
sudo apt-get install libpulse-mainloop-glib0
shell: bash
Expand All @@ -62,10 +70,12 @@ jobs:
run: edm install -y wheel click coverage
- name: Install test environment
run: edm run -- python etstool.py install --toolkit=${{ matrix.toolkit }} --source
- name: Run tests
uses: GabrielBB/xvfb-action@v1
with:
run: edm run -- python etstool.py test --toolkit=${{ matrix.toolkit }}
- name: Run tests (Linux)
if: matrix.os == 'ubuntu-latest'
run: xvfb-run -a edm run -- python etstool.py test --toolkit=${{ matrix.toolkit }}
- name: Run tests (not Linux)
if: matrix.os != 'ubuntu-latest'
run: edm run -- python etstool.py test --toolkit=${{ matrix.toolkit }}

notify-on-failure:
needs: test-with-edm
Expand Down
20 changes: 15 additions & 5 deletions .github/workflows/test-with-edm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
toolkit: ['wx', 'pyqt5', 'pyside2', 'pyside6']
exclude:
- os: ubuntu-latest
toolkit: 'wx'
timeout-minutes: 20 # should be plenty, it's usually < 5
runs-on: ${{ matrix.os }}
env:
Expand All @@ -31,14 +34,19 @@ jobs:
- name: Install Qt dependencies for Linux
run: |
sudo apt-get update
sudo apt-get install qt5-default
sudo apt-get install qtbase5-dev
sudo apt-get install qtchooser
sudo apt-get install qt5-qmake
sudo apt-get install qtbase5-dev-tools
sudo apt-get install libegl1
sudo apt-get install libxkbcommon-x11-0
sudo apt-get install libxcb-icccm4
sudo apt-get install libxcb-image0
sudo apt-get install libxcb-keysyms1
sudo apt-get install libxcb-randr0
sudo apt-get install libxcb-render-util0
sudo apt-get install libxcb-xinerama0
sudo apt-get install libxcb-shape0
sudo apt-get install pulseaudio
sudo apt-get install libpulse-mainloop-glib0
sudo apt-get install libgstreamer-gl1.0-0
Expand All @@ -64,7 +72,9 @@ jobs:
run: edm install -y wheel click coverage
- name: Install test environment
run: edm run -- python etstool.py install --toolkit=${{ matrix.toolkit }}
- name: Run tests
uses: GabrielBB/xvfb-action@v1
with:
run: edm run -- python etstool.py test --toolkit=${{ matrix.toolkit }}
- name: Run tests (Linux)
if: matrix.os == 'ubuntu-latest'
run: xvfb-run -a edm run -- python etstool.py test --toolkit=${{ matrix.toolkit }}
- name: Run tests (not Linux)
if: matrix.os != 'ubuntu-latest'
run: edm run -- python etstool.py test --toolkit=${{ matrix.toolkit }}

0 comments on commit 9fc3bbc

Please sign in to comment.