Dont rely on the existence of "select" on entry points #1000
Conversation
This commit adds a compatibility layer to the entry point code to handle the absence of the select method on entry points. Additionally, we now rely on the external importlib_metadata first and only if that is absent do we rely on importlib.metadata from the standard library modified: pyface/base_toolkit.py modified: pyface/tests/test_toolkit.py
|
@mdickinson do you have the bandwidth to review? |
pyface/base_toolkit.py
Outdated
| @@ -68,11 +68,14 @@ | |||
| import sys | |||
|
|
|||
| try: | |||
| import importlib_metadata | |||
There was a problem hiding this comment.
I'd prefer something that defaults to the std. lib. functionality where it's available and only uses importlib_metadata as a fallback, since the std. lib. is really what we want to be using: we don't want to be relying on the 3rd party version for any longer than we have to.
With the changes below, we don't actually need to do this reversal, right?
There was a problem hiding this comment.
with these changes, we don't need this reversal but I still chose the reversal specifically we made importlib_metadata a required dependency for Python < 3.10 -
Line 22 in 91c93ae
There was a problem hiding this comment.
Understood, but I'd prefer to get rid of the importlib_metadata dependency as soon as we can - i.e., with Python 3.8.
and limit the dependency on external importlib_metadata to python < 3.8 modified: pyface/__init__.py modified: pyface/base_toolkit.py modified: pyface/tests/test_toolkit.py
|
@mdickinson can you re-review this PR? I've removed the import reversal - and removed the dependence on external |
This PR adds a compatibility layer to the entry point code to handle the absence of the
selectmethod on entry points. Additionally, we now rely on the externalimportlib_metadatafirst and only if that is absent do we rely onimportlib.metadatafrom the standard library.fixes #998
Note to reviewer : I tested this locally by creating a python 3.9 virtual environment, installing pyface and relevent test dependencies and running the testsuite. On this branch, I don't see the
select-related test errors that we see on themasterbranch.