Tests for ImageLibrary and related code #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are more integration tests than unit tests, and don't attempt to test anything which changes global state (eg. adding to ImageLibrary, etc)
rahulporuri
approved these changes
Aug 9, 2021
| def test_no_at_symbol(self): | ||
| volume_name, file_name = split_image_name("icons:red_ball.jpg") | ||
|
|
||
| # XXX this should probably raise rather than doing this |
There was a problem hiding this comment.
Do you think it makes sense to open an issue for this instead of leaving this information hidden in a comment in a test?
There was a problem hiding this comment.
Done: #1015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are more integration tests than unit tests, and don't attempt to test anything which changes global state (eg. adding to ImageLibrary, etc).
Total coverage is ~68%, but that's a lot better than 0 and these tests will hopefully be enough to: