Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update almost all _fired methods to use observe #1005

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Conversation

aaronayres35
Copy link
Contributor

This PR simply replaces almost all uses of the _fired magically named methods with their observe equivalent.

The only lingering method is here:

def _finished_fired(self, result):
""" Called when the dialog is closed (and nonmodal). """
self.return_code = _RESULT_MAP[result]
self.close()

Which I believe will need special care because this is also making use of the qt signal handling
dlg.finished.connect(self._finished_fired)

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Looks like you committed the changes to icons.zip and std.zip files.

@aaronayres35 aaronayres35 merged commit 0668ddc into master Jul 27, 2021
@aaronayres35 aaronayres35 deleted the _fired-to-observe branch July 27, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants