Widget context menus #1020
Merged
Widget context menus #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a straightforward move of code from Fields to Widgets, which is possible now the _add_event_notifiers, etc. has been standardized,
|
@corranwebster CI is failing on this PR as well on the wx toolkit |
|
|
rahulporuri
approved these changes
Sep 20, 2021
| @@ -35,6 +35,9 @@ class IWidget(Interface): | |||
| #: A tooltip for the widget. | |||
| tooltip = Str() | |||
|
|
|||
| #: An optional context menu for the widget. | |||
| context_menu = Instance("pyface.action.menu_manager.MenuManager") | |||
There was a problem hiding this comment.
What about the show_context_menu method that is defined on the IField interface? Update : It looks like an undefined/unused part of the IField interface which we're choosing not to carry over.
There was a problem hiding this comment.
Yes, I realized it wasn't hooked up to anything, so no reason to carry it over.
Comment on lines
-43
to
-46
| wx.EVT_CONTEXT_MENU, handler=self._handle_context_menu | ||
| ) | ||
| else: | ||
| self.control.Bind(wx.EVT_CONTEXT_MENU, self._handle_context_menu) |
There was a problem hiding this comment.
looks like there was a bug here which we coincidentally fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is doing essentially the same as #1019 but for context menus, so that now any widget can have a context menu attached to it.
One consequence of this is that
Fieldand the testing code for field have become very thin with no toolkit-specific code at all. This PR is leaving them in that state, but I will open an issue to either do a clean-up or add some meat to them.