Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #539 #1141

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Fix for #539 #1141

merged 2 commits into from
Jul 2, 2022

Conversation

johannesloibl
Copy link
Contributor

No description provided.

@johannesloibl
ApplicationWindow isn't cleaning up StatusBarManager (enthought#539)
a1d2b16 
- Streamline naming of destroy function of StatusBarManager Qt and wx implementation
- Add destroying of StatusBarManager when application is destroyed
@johannesloibl
Rename references (enthought#539 cont.)
fae180f
corranwebster
corranwebster approved these changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks good.

@corranwebster corranwebster merged commit d0922a2 into enthought:main Jul 2, 2022
corranwebster pushed a commit that referenced this pull request Jul 4, 2022
@johannesloibl @corranwebster
Fix for #539 (#1141)
66793cb 
* ApplicationWindow isn't cleaning up StatusBarManager (#539)

- Streamline naming of destroy function of StatusBarManager Qt and wx implementation
- Add destroying of StatusBarManager when application is destroyed

* Rename references (#539 cont.)
corranwebster pushed a commit that referenced this pull request Jul 11, 2022
@johannesloibl @corranwebster
Fix for #539 (#1141)
9dc851a 
* ApplicationWindow isn't cleaning up StatusBarManager (#539)

- Streamline naming of destroy function of StatusBarManager Qt and wx implementation
- Add destroying of StatusBarManager when application is destroyed

* Rename references (#539 cont.)
@greschd greschd mentioned this pull request Mar 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannesloibl @corranwebster