Include cause of toolkit import failure #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
approved these changes
Aug 11, 2022
corranwebster
added
the
needs backport to maint/*
corranwebster
pushed a commit
that referenced
this pull request
Nov 11, 2022
corranwebster
pushed a commit
that referenced
this pull request
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
RuntimeErrorthat appears when no toolkit can be loaded to include the immediate cause of the failure. The goal is to make debugging CI failures along these lines less painful: theRuntimeErroris often caused by some obscureImportErrorsomewhere down the stack, and with the current code that import error is hidden from view in the CI output.