Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic DataView Implementation #543

Merged
merged 52 commits into from
Jul 14, 2020
Merged

Basic DataView Implementation #543

merged 52 commits into from
Jul 14, 2020

Commits on Jun 1, 2020

  1. First cut a data_view that can display successfully.

    @corranwebster
    corranwebster committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    6fca300 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Add a column-based data model and corresponding example.

    @corranwebster
    corranwebster committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    70ba5f0 View commit details
    Browse the repository at this point in the history

  2. Add missing file.

    @corranwebster
    corranwebster committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    fa3c892 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Target code for basic data view implementation.

    @corranwebster
    corranwebster committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    3bfaaaa View commit details
    Browse the repository at this point in the history

  2. Update abstract data model docstrings.

    @corranwebster
    corranwebster committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    02c7af7 View commit details
    Browse the repository at this point in the history

  3. Lots more docstrings, some additional clean-up and API clarification.

    @corranwebster
    corranwebster committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5f1de11 View commit details
    Browse the repository at this point in the history

  4. More and better tests.

    @corranwebster
    corranwebster committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5b4b43a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Fix up wx widget scaffolding.

    @corranwebster
    corranwebster committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    15554b2 View commit details
    Browse the repository at this point in the history

  2. Add documentation for the DataModel with an example.

    @corranwebster
    corranwebster committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f06bd98 View commit details
    Browse the repository at this point in the history

  3. Fix references.

    @corranwebster
    corranwebster committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bc36909 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Move the column data model to the examples, clean up example.

    @corranwebster
    corranwebster committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    cce14b1 View commit details
    Browse the repository at this point in the history

  2. Add copyright headers.

    @corranwebster
    corranwebster committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    a561645 View commit details
    Browse the repository at this point in the history

  3. Add tests for remaining value type classes.

    @corranwebster
    corranwebster committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    45fd7ed View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Ieva <[email protected]>
    @corranwebster @ievacerny
    corranwebster and ievacerny authored Jun 22, 2020
    Configuration menu
    Copy the full SHA
    9208713 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Updates and fixes from PR review.

    @corranwebster
    corranwebster committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    597f869 View commit details
    Browse the repository at this point in the history

  2. Add some more tests, improve a comment.

    @corranwebster
    corranwebster committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    23b852d View commit details
    Browse the repository at this point in the history

  3. Get a smoke test working for the DataViewWidget class.

    @corranwebster
    corranwebster committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    8a9f49e View commit details
    Browse the repository at this point in the history

  4. More clean-up of the toolkit implementations.

    @corranwebster
    corranwebster committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    8e70092 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Ieva <[email protected]>
    @corranwebster @ievacerny
    corranwebster and ievacerny authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    d50d7ef View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Fixes based in PR suggestions.

    @corranwebster
    corranwebster committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    4792f66 View commit details
    Browse the repository at this point in the history

  2. Fix flake8 issue.

    @corranwebster
    corranwebster committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    6f2d37f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Convert from lists for indices to tuples.

    @corranwebster
    corranwebster committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    eabf7f5 View commit details
    Browse the repository at this point in the history

  2. Fix bug in set method.

    @corranwebster
    corranwebster committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    483db31 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Make column count constant, plus some small fixes.

    @corranwebster
    corranwebster committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    7e8ba1e View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Release model when destroying widgets.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a96ac32 View commit details
    Browse the repository at this point in the history

  2. Fix docstrings.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1cc2caf View commit details
    Browse the repository at this point in the history

  3. Rename "editable" -> "editor_value".

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3defcee View commit details
    Browse the repository at this point in the history

  4. And "editable" -> "editro_value" in other files.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e9d680d View commit details
    Browse the repository at this point in the history

  5. Improve TextValue and NumericValues.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    9be4d98 View commit details
    Browse the repository at this point in the history

  6. Fix spelling.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8341a2d View commit details
    Browse the repository at this point in the history

  7. Instantiate exceptions.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    277a966 View commit details
    Browse the repository at this point in the history

  8. Move to using exceptions to handle failure to set values.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a02a48b View commit details
    Browse the repository at this point in the history

  9. Fix iteration over columns.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4929afe View commit details
    Browse the repository at this point in the history

  10. Use more descriptive metadata for updating value types.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4b0efee View commit details
    Browse the repository at this point in the history

  11. Don't try to guess value type for array model, ensure 2d arrays.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7d12b2a View commit details
    Browse the repository at this point in the history

  12. Add a test for setting 1d data.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    262bc5b View commit details
    Browse the repository at this point in the history

  13. And test default data is 2d.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fde28c2 View commit details
    Browse the repository at this point in the history

  14. Improve tests of empty data.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    62a38c7 View commit details
    Browse the repository at this point in the history

  15. Assorted fixes from PR review.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2aa4c11 View commit details
    Browse the repository at this point in the history

  16. Dispatch model changes on the ui thread.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    25009ef View commit details
    Browse the repository at this point in the history

  17. Cleanup of confusing parentheses.

    @corranwebster
    corranwebster committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e3d625f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Improve documentation for data view.

    @corranwebster
    corranwebster committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    bb5c380 View commit details
    Browse the repository at this point in the history

  2. Minro fixes and improvements to documentation.

    @corranwebster
    corranwebster committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    aab3854 View commit details
    Browse the repository at this point in the history

  3. Remove ui dispatch from pure data models.

    @corranwebster
    corranwebster committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b4ccec7 View commit details
    Browse the repository at this point in the history

  4. Docstring fixes.

    @corranwebster
    corranwebster committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f382d71 View commit details
    Browse the repository at this point in the history

  5. More fixes from PR review.

    @corranwebster
    corranwebster committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    65a1ebe View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Change the way that we handle low-dimension arrays.

    @corranwebster
    corranwebster committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    4b0f75a View commit details
    Browse the repository at this point in the history

  2. Handle unusual life-cycle issues.

    @corranwebster
    corranwebster committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    89748c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Remove extraneous file commited.

    @corranwebster
    corranwebster committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    b559ac5 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Kit Choi <[email protected]>
    @corranwebster @kitchoi
    corranwebster and kitchoi authored Jul 14, 2020
    Configuration menu
    Copy the full SHA
    b92e062 View commit details
    Browse the repository at this point in the history

  2. various fixes and improvements from review.

    @corranwebster
    corranwebster committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    83a80ca View commit details
    Browse the repository at this point in the history

  3. Add missing import.

    @corranwebster
    corranwebster committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    516cc22 View commit details
    Browse the repository at this point in the history