Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker dialog for Color objects/PyfaceColor trait #711

Merged
merged 5 commits into from
Sep 28, 2021

Conversation

corranwebster
Copy link
Contributor

This is the last part of #534 pulled out into its own PR.

I'm leaving this as a draft because right now I don't trust the tests being run by the modal dialog tester.

@corranwebster
Copy link
Contributor Author

See also #534 (review) - there may be some problems with wx.

@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #711 into master will increase coverage by 1.17%.
The diff coverage is 90.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   39.76%   40.94%   +1.17%     
==========================================
  Files         493      510      +17     
  Lines       27259    27882     +623     
  Branches     4140     4225      +85     
==========================================
+ Hits        10840    11415     +575     
- Misses      15944    15992      +48     
  Partials      475      475              
Impacted Files Coverage Δ
pyface/ui/qt4/data_view/data_view_item_model.py 55.46% <35.71%> (+5.46%) ⬆️
pyface/ui/wx/color_dialog.py 53.57% <53.57%> (ø)
pyface/color_dialog.py 80.00% <80.00%> (ø)
pyface/ui/wx/data_view/data_wrapper.py 86.36% <86.36%> (ø)
pyface/ui/qt4/color_dialog.py 87.50% <87.50%> (ø)
...face/data_view/data_models/row_table_data_model.py 91.25% <91.25%> (ø)
pyface/data_view/i_data_wrapper.py 92.30% <92.30%> (ø)
pyface/ui_traits.py 86.11% <93.93%> (+2.32%) ⬆️
pyface/data_view/value_types/color_value.py 95.45% <95.45%> (ø)
pyface/color.py 100.00% <100.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98015c...fedc3d7. Read the comment docs.

@corranwebster corranwebster added this to the Release 7.4.0 milestone Sep 28, 2021
@corranwebster corranwebster marked this pull request as ready for review September 28, 2021 10:51
pyface/color_dialog.py Outdated Show resolved Hide resolved
Co-authored-by: Poruri Sai Rahul <[email protected]>
@corranwebster corranwebster merged commit 7393562 into main Sep 28, 2021
@corranwebster corranwebster deleted the feat/color-dialog branch September 28, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants