Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Trait Types #728

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Update Trait Types #728

merged 6 commits into from
Sep 28, 2021

Conversation

corranwebster
Copy link
Contributor

This PR replaces Either with Union and some uses of Trait with Map.

This breaks compatibility with Traits 6.0, and should not be merged until after Pyface 7.1 is released.

@corranwebster
Copy link
Contributor Author

Failure is an expected failure when running against Traits 6.0.

@corranwebster corranwebster added this to the Release 7.4.0 milestone Sep 28, 2021
@corranwebster corranwebster marked this pull request as ready for review September 28, 2021 11:10
rahulporuri
rahulporuri approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

pyface/timer/i_timer.py Outdated Show resolved Hide resolved
@corranwebster
Update pyface/timer/i_timer.py
22c1d60 
Co-authored-by: Poruri Sai Rahul <[email protected]>
@corranwebster corranwebster merged commit 522aa38 into main Sep 28, 2021
@corranwebster corranwebster deleted the enh/replace-either-with-union branch September 28, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 7.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@corranwebster @rahulporuri