-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation instruction on README #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.rst
Outdated
|
||
$ pip install pyface[pyqt5] | ||
|
||
To install with wxPython dependencies (experimental):: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should specify wxPython 4?
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 40.67% 40.88% +0.21%
==========================================
Files 508 508
Lines 27832 27832
Branches 4217 4217
==========================================
+ Hits 11320 11379 +59
+ Misses 16016 15979 -37
+ Partials 496 474 -22
Continue to review full report at Codecov.
|
will run tests in all supported environments automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... I tried to change 'wxPython' to 'wxPython4' via GitHub directly and GitHub did this change for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds the missing newline at the end of file, and I am going to merge away...
This PR updates the README for Pyface (also visible on PyPI page) to provide installation instructions for optional dependencies.