Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare python_requires to support Python >= 3.6 #850

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Dec 15, 2020

Closes #845

This PR updates setup.py such that package installer will avoid the next release if the Python version is less than 3.6.

Pyface no longer supports Python 2, and CI for Python 3.5 has been removed so it would be difficult to continue its support, Python 3.5 has also reached its end-of-life.

Similar to enthought/traitsui#1436

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit 3a05cca into master Dec 16, 2020
@kitchoi kitchoi deleted the declare-python-requires branch December 16, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declare Python 3.5 unsupported
2 participants