Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running:
I was seeing the following test failure:
This PR simply updates that test file to skip the test if
wx
is not available in the environment.Looking into this also made me realize that there is no consistent way this type of thing is done across the codebase. For example:
pyface/pyface/ui/wx/grid/tests/test_simple_grid_model.py
Lines 12 to 20 in 8cc824e
pyface/pyface/action/tests/test_traitsui_widget_action.py
Line 25 in 8cc824e
pyface/pyface/tests/test_api.py
Lines 17 to 18 in 8cc824e
pyface/pyface/tasks/tests/test_dock_pane_toggle_group.py
Line 26 in 8cc824e
sometimes trying the import, something working with
toolkit
frompyface.toolkit
sometimes throughETSConfig.toolkit
, etc. It is pretty inconsequential (they all do what we want), but it would be good to pin down a consistent way to skip tests based on toolkit.