New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib.resources.files and importlib.metadata if available #943

Merged

rahulporuri merged 1 commit into master from fix/dont-require-3rd-party-importlib-subpackages

Jun 14, 2021

Member

mdickinson commented Jun 14, 2021

This PR:

updates the core code to use importlib.resources.files in preference to importlib_resources.files
updates the setup.py requirements so that importlib_resources and importlib_metadata aren't installed if they're not needed

Closes #942.


          Use importlib.resources.files and importlib.metadata if available

adb0a11

rahulporuri approved these changes

View reviewed changes

Contributor

rahulporuri left a comment

LGTM.

I tested this locally on Python 3.7 and 3.9 and everything looked good.

rahulporuri merged commit f89fcfb into master

rahulporuri deleted the fix/dont-require-3rd-party-importlib-subpackages branch

June 14, 2021 13:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet