Cleanup super usage in toolkit agnostic code #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up the super usage in the toolkit-agnostic pyface code using semi-automated regex-based search and replace. Note that this commit removes a redundant redefinition of __init__
rahulporuri
commented
Jun 14, 2021
Comment on lines
-3833
to
-3834
| def __init__(self, **kw): | ||
| super(DockInfo, self).__init__(**kw) |
There was a problem hiding this comment.
this is an unnecessary redefinition of __init__ which we removed
aaronayres35
approved these changes
Jun 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
superusage in a semi-automated fashion. We used regex-based search and replace to update thesuperusage. Note that there was one unnnecessary redefinition of__init__which got removed in this PR.See similar PR #944, #945 and enthought/traits#1280