Make EventLoopHelper expect an IGUI instance #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Jun 17, 2021
| from traits.api import HasTraits, provides | ||
|
|
||
| from pyface.i_gui import IGUI | ||
| from pyface.ui.qt4.util.event_loop_helper import EventLoopHelper |
There was a problem hiding this comment.
Isn't there a toolkit-agnostic way of getting the EventLoopHelper? If there is, we can make this test toolkit-agnostic, which it should be IMO
There was a problem hiding this comment.
I will do this in a follow up PR since we need to add the generic module for it (similar to #926)
Co-authored-by: Poruri Sai Rahul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #701
This PR follows the lead of enthought/envisage#301