PIL/Pillow image class #960
Conversation
rahulporuri
requested review from
rahulporuri
and removed request for
rahulporuri
|
i'm removing myself as a reviewer for now - i'll wait until after #959 is merged. |
|
This makes pillow an optional dependency:
|
| # | ||
| # Thanks for using Enthought open source! | ||
|
|
||
| from pyface.qt.QtGui import QIcon, QPixmap |
There was a problem hiding this comment.
Tangent : I always wondered why these Never mind. I think it's because the pyface.qt imports preceeded other imports. Why is that?pyface.qt imports are technically Qt-imports which are third party packages and so they should exist before Enthought library imports.
I wish this was codified somewhere because the answer isn't obvious.
There was a problem hiding this comment.
It's not done universally. In this case it was likely just copy-pasted from image_resource.py. In other cases as you note it's likely from taking Wx code and translating it and so the Wx imports get replaced by Qt imports in the same place.
It would be nice to standardize, but that would require going through and actually standardizing
pyface/ui/wx/util/image_helpers.py
Outdated
| @@ -33,7 +33,6 @@ class AspectRatio(IntEnum): | |||
|
|
|||
| def image_to_bitmap(image): | |||
| """ Convert a wx.Image to a wx.Bitmap. | |||
|
|
|||
There was a problem hiding this comment.
Don't we normally have a new line in the function docstring between the description and the parameters?
There was a problem hiding this comment.
Yes. Not sure what happened here. It might be a bad merge.
Co-authored-by: Poruri Sai Rahul <[email protected]>
Co-authored-by: Poruri Sai Rahul <[email protected]>
|
Right, I think this is good. If everything passes I will merge. |
This builds on #959 to provide an image class for PIL/Pillow
Imageinstances. This is part of #909 but not essential to it - we could decide to defer PIL support.This adds an optional dependency on
pillow- this is already a dependency of WxPython, so this is only potentially a problem for Qt users.