Toggle Fields (CheckBoxField, RadioButtonField, etc.) #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Jun 23, 2021
docs/source/fields.rst
Outdated
|
|
||
| The :py:class:`~pyface.fields.i_toggle_field.IToggleField` interface holds a | ||
| boolean :py:attr:`~pyface.fields.i_spin_field.IToggleField.value` that is |
There was a problem hiding this comment.
should this be
Suggested change
| boolean :py:attr:`~pyface.fields.i_spin_field.IToggleField.value` that is | |
| boolean :py:attr:`~pyface.fields.i_toggle_field.IToggleField.value` that is |
pyface/fields/toggle_field.py
Outdated
Comment on lines
10
to
12
| # | ||
| # Author: Enthought, Inc. | ||
| # Description: <Enthought pyface package component> |
There was a problem hiding this comment.
nit: do we really need these or were they copy-pasted from some other module?
There was a problem hiding this comment.
Copy-pasted. I don't think we've done the header normalization for pyface: some of the copyright dates were also out of sync.
- correct references in docs - fixes to copyright headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional fields with toggling behaviour: check boxes, radio buttons, and toggle buttons.
The purpose of this functionality is to abstract the common API to permit an eventual refactor of the TraitsUI
BooleanEditorto allow styles other than checkboxes.