Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simplesat build #287

Merged
merged 13 commits into from
Sep 6, 2024
Merged

Fix simplesat build #287

merged 13 commits into from
Sep 6, 2024

Conversation

itziakos
Copy link
Member

@itziakos itziakos commented Sep 5, 2024 •
edited
Loading

  • Simplify the package build scripts (use setup.cfg)
  • Add more files and folders to sdist
  • Cleanup old dev files
  • Update workflow to fix artifact upload

fixes #286

itziakos
itziakos commented Sep 5, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
itziakos
itziakos commented Sep 5, 2024
View reviewed changes
Copy link
Member Author

@itziakos itziakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks ok

@itziakos itziakos requested a review from dpinte September 5, 2024 20:22
dpinte
dpinte approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@itziakos itziakos merged commit 97df5e6 into main Sep 6, 2024
16 checks passed
@itziakos itziakos deleted the fix-simplesat-build branch September 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinte dpinte dpinte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The 0.9.0 wheel is broken
2 participants
@itziakos @dpinte