Rename module _i_observable to i_observable #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
approved these changes
Sep 23, 2020
|
Ah, unusually, it looks as though we're waiting for Travis rather than Appveyor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
traits.observation._i_observablemodule totraits.observation.i_observablebecause it is used by packages outside oftraits.observationbut insidetraitsfor implementingIObservable.There are two other interfaces within
traits.observationbut they have only been used withintraits.observationso there is so far no need to expose them.Checklist
- [ ] Tests- [ ] Update API reference (. <--- i_observable is not visible on the API reference. So far it has only been used internally in traits, there isn't an external use case yetdocs/source/traits_api_reference)- [ ] Update User manual (docs/source/traits_user_manual)- [ ] Update type annotation hints intraits-stubs