Skip to content

Commit

Permalink
Merge pull request #235 from envato/EventPersisted
Browse files Browse the repository at this point in the history
Event.persisted? is potentially misleading
  • Loading branch information
andyjdavis authored Dec 20, 2023
2 parents bc5ae31 + 6121a8d commit 0b21aea
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 9 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [1.0.0] - 2023-11-29

### Removed
- Removed Event.persisted? as it was potentially misleading ([#235])

[#235]: https://github.com/envato/event_sourcery/pull/235

## [0.24.0] - 2021-11-18

### Added
Expand Down Expand Up @@ -254,6 +262,7 @@ moving all Postgres related code into a separate gem.
- `Command` and `CommandHandler` have been removed.
[Unreleased]: https://github.com/envato/event_sourcery/compare/v0.24.0...HEAD
[1.0.0]: https://github.com/envato/event_sourcery/compare/v0.24.0...v1.0.0
[0.24.0]: https://github.com/envato/event_sourcery/compare/v0.23.1...v0.24.0
[0.23.1]: https://github.com/envato/event_sourcery/compare/v0.23.0...v0.23.1
[0.23.0]: https://github.com/envato/event_sourcery/compare/v0.22.0...v0.23.0
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ A framework for building event sourced, CQRS applications.

## Development Status

EventSourcery is currently being used in production by multiple apps but we
haven't finalized the API yet and things are still moving rapidly. Until we
release a 1.0 things may change without first being deprecated.
[![Build Status](https://github.com/envato/event_sourcery/workflows/tests/badge.svg?branch=main)](https://github.com/envato/event_sourcery/actions?query=branch%3Amain)

Event Sourcery is in production use at [Envato](http://envato.com).

## Goals

Expand Down
5 changes: 0 additions & 5 deletions lib/event_sourcery/event.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@ def initialize(id: nil,
@causation_id = causation_id
end

# Is this event persisted?
def persisted?
!id.nil?
end

def hash
[self.class, uuid].hash
end
Expand Down
2 changes: 1 addition & 1 deletion lib/event_sourcery/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module EventSourcery
# Defines the version
VERSION = '0.24.0'.freeze
VERSION = '1.0.0'.freeze
end

0 comments on commit 0b21aea

Please sign in to comment.