-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multiple aliases for a single region #221
base: master
Are you sure you want to change the base?
Conversation
@rbayerl could you try explaining the parameters issue you described in another way? I'm not sure I understand the limitation based on what you've described in your last paragraph. |
Using the above example config here's what comes from
Since the parameter lookup directories just creates an array of all aliases these will all be included for all stacks in the region (regardless of the alias where the stack is defined). So parameters for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some tests for this?
Given the age of this PR (our fault) it could also do with a rebase too
Related to #115 and #180 I have hit an issue where only the last region alias defined is actually honored. This simple patch allows for multiple aliases in a single region, but does not set any precedence for parameter resolution. E.g. consider the following:
Parameters for both stacks will look in
parameters/foo
andparameters/bar
. Since one cannot have duplicate stack names in a region IMO this is not a huge issue. This patch will at least allow the option for logicalstack_master.yml
layout and ordering for parameter files.