-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use block height for id on contract import #209
Conversation
true => format!("${{{event_var_name}.transaction.id}}"), | ||
false => format!("${{{event_var_name}.block.number}}"), | ||
let block_number_field = match is_fuel { | ||
true => "heigth", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think height is spelled wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you double check that it works? I think there is a typo.
Fixed and tested 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry looks like another one...
codegenerator/cli/src/hbs_templating/contract_import_templates.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jono Prest <[email protected]>
I'm surprised by my ability making silly mistakes when I'm lazy to test something because I'm 100% sure that it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok cool, looks great 👌🏼
No problem at all 🙏🏼 that's why we have reviews. |
No description provided.