Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix require for the bin.js file #243

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix require for the bin.js file #243

merged 1 commit into from
Oct 1, 2024

Conversation

DZakh
Copy link
Member

@DZakh DZakh commented Oct 1, 2024 •
edited
Loading

require.resolve didn't work correctly with esm.

I get:

image

@DZakh DZakh requested a review from JonoPrest October 1, 2024 14:31
@DZakh DZakh enabled auto-merge (squash) October 1, 2024 14:37
JonoPrest
JonoPrest approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@JonoPrest JonoPrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work when using a ts-node indexer?

@DZakh DZakh merged commit a236a89 into main Oct 1, 2024
1 check passed
@DZakh DZakh deleted the dz/fix-require branch October 1, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonoPrest JonoPrest JonoPrest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DZakh @JonoPrest