Skip to content

Commit

Permalink
api: deprecate the node.listening_addresses field (#12691)
Browse files Browse the repository at this point in the history
This was added for gRPC server support, but we've decided to use resource names instead to explicitly request the listeners we want by name. This is more in-line with the new naming scheme described in the "xDS Transport Next Steps" design.

Signed-off-by: Mark D. Roth <[email protected]>
  • Loading branch information
markdroth authored Aug 17, 2020
1 parent 0f89615 commit 05cbb30
Show file tree
Hide file tree
Showing 40 changed files with 1,601 additions and 44 deletions.
14 changes: 7 additions & 7 deletions api/envoy/admin/v4alpha/config_dump.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/envoy/config/core/v3/base.proto
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ message Node {
// for filtering :ref:`listeners <config_listeners>` to be returned. For example,
// if there is a listener bound to port 80, the list can optionally contain the
// SocketAddress `(0.0.0.0,80)`. The field is optional and just a hint.
repeated Address listening_addresses = 11;
repeated Address listening_addresses = 11 [deprecated = true];
}

// Metadata provides additional inputs to filters based on matched listeners,
Expand Down
11 changes: 2 additions & 9 deletions api/envoy/config/core/v4alpha/base.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/envoy/config/metrics/v4alpha/metrics_service.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/envoy/config/route/v4alpha/scoped_route.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions api/envoy/service/accesslog/v4alpha/BUILD

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

87 changes: 87 additions & 0 deletions api/envoy/service/accesslog/v4alpha/als.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions api/envoy/service/discovery/v4alpha/BUILD

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 44 additions & 0 deletions api/envoy/service/discovery/v4alpha/ads.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 05cbb30

Please sign in to comment.