Skip to content

Commit

Permalink
Fixes gcc 8.3.1 build failure due to FilterChainBenchmarkFixture::Set…
Browse files Browse the repository at this point in the history
…Up hiding base-class virtual functions (#8071)

Description: I'm seeing "bazel-out/k8-fastbuild/bin/external/com_github_google_benchmark/_virtual_includes/benchmark/benchmark/benchmark.h:1071:16: error: 'virtual void benchmark::Fixture::SetUp(benchmark::State&)' was hidden" when running tests. This resolves the issue with hiding of the base-class functions.
Risk Level: low
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Dmitri Dolguikh <[email protected]>
  • Loading branch information
Dmitri Dolguikh authored and lizan committed Aug 29, 2019
1 parent 7f060b6 commit 0fde42e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/server/filter_chain_benchmark_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ const char YamlSingleDstPortBottom[] = R"EOF(

class FilterChainBenchmarkFixture : public benchmark::Fixture {
public:
using Fixture::SetUp;
void SetUp(const ::benchmark::State& state) override {
int64_t input_size = state.range(0);
std::vector<std::string> port_chains;
Expand Down

0 comments on commit 0fde42e

Please sign in to comment.