tools: sync tool for envoyproxy/assignable team. (#8015)

Bulk update of team to match envoyproxy organization. While at it, cleaned up some venv stuff in
shell_utils.sh.

Risk level: Low
Testing: Synced 157 members from envoyproxy to envoyproxy/assignable.

Signed-off-by: Harvey Tuch <[email protected]>

tools/deprecate_features/deprecate_features.sh

@@ -4,11 +4,4 @@
 
 set -e
 
-SCRIPT_DIR=$(realpath "$(dirname "$0")")
-BUILD_DIR=build_tools
-VENV_DIR="$BUILD_DIR"/deprecate_features
-
-source_venv "$VENV_DIR"
-pip install -r "${SCRIPT_DIR}"/requirements.txt
-
-python "${SCRIPT_DIR}/deprecate_features.py" $*
+python_venv deprecate_features

tools/deprecate_version/deprecate_version.sh

@@ -4,11 +4,4 @@
 
 set -e
 
-SCRIPT_DIR=$(realpath "$(dirname "$0")")
-BUILD_DIR=build_tools
-VENV_DIR="$BUILD_DIR"/deprecate_version
-
-source_venv "$VENV_DIR"
-pip install -r "${SCRIPT_DIR}"/requirements.txt
-
-python "${SCRIPT_DIR}/deprecate_version.py" $*
+python_venv deprecate_version

tools/github/requirements.txt

@@ -0,0 +1 @@
+PyGithub==1.43.8

tools/github/sync_assignable.py

@@ -0,0 +1,53 @@
+# Sync envoyproxy organization users to envoyproxy/assignable team.
+#
+# This can be used for bulk cleanups if envoyproxy/assignable is not consistent
+# with organization membership. In general, prefer to add new members by editing
+# the envoyproxy/assignable in the GitHub UI, which will also cause an
+# organization invite to be sent; this reduces the need to manually manage
+# access tokens.
+#
+# Note: the access token supplied must have admin:org (write:org, read:org)
+# permissions (and ideally be scoped no more widely than this). See Settings ->
+# Developer settings -> Personal access tokens for access token generation.
+# Ideally, these should be cleaned up after use.
+
+import os
+import sys
+
+import github
+
+
+def GetConfirmation():
+  """Obtain stdin confirmation to add users in GH."""
+  return input('Add users to envoyproxy/assignable ? [yN] ').strip().lower() in ('y', 'yes')
+
+
+def SyncAssignable(access_token):
+  organization = github.Github(access_token).get_organization('envoyproxy')
+  team = organization.get_team_by_slug('assignable')
+  organization_members = set(organization.get_members())
+  assignable_members = set(team.get_members())
+  missing = organization_members.difference(assignable_members)
+
+  if not missing:
+    print('envoyproxy/assignable is consistent with organization membership.')
+    return 0
+
+  print('The following organization members are missing from envoyproxy/assignable:')
+  for m in missing:
+    print(m.login)
+
+  if not GetConfirmation():
+    return 1
+
+  for m in missing:
+    team.add_membership(m, 'member')
+
+
+if __name__ == '__main__':
+  access_token = os.getenv('GH_ACCESS_TOKEN')
+  if not access_token:
+    print('Missing GH_ACCESS_TOKEN')
+    sys.exit(1)
+
+  sys.exit(SyncAssignable(access_token))

tools/github/sync_assignable.sh

@@ -0,0 +1,7 @@
+#!/bin/bash
+
+. tools/shell_utils.sh
+
+set -e
+
+python_venv sync_assignable

tools/shell_utils.sh

@@ -9,3 +9,15 @@ source_venv() {
     echo "Found existing virtualenv"
   fi
 }
+
+python_venv() {
+  SCRIPT_DIR=$(realpath "$(dirname "$0")")
+
+  BUILD_DIR=build_tools
+  VENV_DIR="$BUILD_DIR/$1"
+
+  source_venv "$VENV_DIR"
+  pip install -r "${SCRIPT_DIR}"/requirements.txt
+
+  python3 "${SCRIPT_DIR}/$1.py" $*
+}