Skip to content

Commit

Permalink
build: bump vtprotobuf dependency
Browse files Browse the repository at this point in the history
This picks up a few bug fixes and allows us to remove our build tag
hacks

Signed-off-by: John Howard <[email protected]>
  • Loading branch information
howardjohn committed Apr 5, 2024
1 parent 01ed2a7 commit a0448f5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
5 changes: 4 additions & 1 deletion api/bazel/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ exports_files([

go_proto_compiler(
name = "vtprotobuf_plugin_go",
options = ["features=marshal_strict+size"],
options = [
"features=marshal_strict+size",
"buildTag=vtprotobuf",
],
plugin = "@com_github_planetscale_vtprotobuf//cmd/protoc-gen-go-vtproto",
suffix = "_vtproto.pb.go",
valid_archive = False,
Expand Down
4 changes: 2 additions & 2 deletions bazel/dependency_imports.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ def envoy_dependency_imports(go_version = GO_VERSION, jq_version = JQ_VERSION, y
go_repository(
name = "com_github_planetscale_vtprotobuf",
importpath = "github.com/planetscale/vtprotobuf",
sum = "h1:nve54OLsoKDQhb8ZnnHHUyvAK3vjBiwTEJeC3UsqzJ8=",
version = "v0.5.1-0.20231205081218-d930d8ac92f8",
sum = "h1:GFCKgmp0tecUJ0sJuv4pzYCqS9+RGSn52M3FUwPs+uo=",
version = "v0.6.1-0.20240319094008-0393e58bdf10",
build_external = "external",
)

Expand Down
7 changes: 0 additions & 7 deletions ci/do_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -308,13 +308,6 @@ case $CI_TARGET in
if [[ "$GO_FILE" = *.validate.go ]]; then
sed -i '1s;^;//go:build !disable_pgv\n;' "$OUTPUT_DIR/$(basename "$GO_FILE")"
fi
# TODO(https://github.com/planetscale/vtprotobuf/pull/122) do this directly in the generator.
# Make vtprotobuf opt-in as it has some impact on binary sizes
if [[ "$GO_FILE" = *_vtproto.pb.go ]]; then
if ! grep -q 'package ignore' "$GO_FILE"; then
sed -i '1s;^;//go:build vtprotobuf\n// +build vtprotobuf\n;' "$OUTPUT_DIR/$(basename "$GO_FILE")"
fi
fi
done <<< "$(find "$INPUT_DIR" -name "*.go")"
done
;;
Expand Down

0 comments on commit a0448f5

Please sign in to comment.