build: Remove chromium_url (#12023)

This removes chromium_url in favor of GURL. Risk Level: Low Testing: Existing tests Docs Changes: N/A Release Notes: N/A Fixes: #6588 Signed-off-by: Dhi Aurrahman <[email protected]>
envoyproxy · Jul 10, 2020 · d828958 · d828958
1 parent 706d976
commit d828958
Show file tree

Hide file tree

Showing 17 changed files with 12 additions and 1,377 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -128,7 +128,7 @@ build:coverage --strategy=CoverageReport=sandboxed,local
 build:coverage --experimental_use_llvm_covmap
 build:coverage --collect_code_coverage
 build:coverage --test_tag_filters=-nocoverage
-build:coverage --instrumentation_filter="//source(?!/common/chromium_url|/extensions/quic_listeners/quiche/platform)[/:],//include[/:]"
+build:coverage --instrumentation_filter="//source(?!/extensions/quic_listeners/quiche/platform)[/:],//include[/:]"
 coverage:test-coverage --test_arg="-l trace"
 coverage:fuzz-coverage --config=asan-fuzzer
 coverage:fuzz-coverage --run_under=@envoy//bazel/coverage:fuzz_coverage_wrapper.sh

diff --git a/ci/run_clang_tidy.sh b/ci/run_clang_tidy.sh
@@ -50,19 +50,13 @@ function exclude_testdata() {
   grep -v tools/testdata/check_format/
 }
 
-# Do not run clang-tidy against Chromium URL import, this needs to largely
-# reflect the upstream structure.
-function exclude_chromium_url() {
-  grep -v source/common/chromium_url/
-}
-
 # Exclude files in third_party which are temporary forks from other OSS projects.
 function exclude_third_party() {
   grep -v third_party/
 }
 
 function filter_excludes() {
-  exclude_testdata | exclude_chromium_url | exclude_win32_impl | exclude_macos_impl | exclude_third_party
+  exclude_testdata | exclude_win32_impl | exclude_macos_impl | exclude_third_party
 }
 
 if [[ -z "${DIFF_REF}" && "${BUILD_REASON}" != "PullRequest" ]]; then

diff --git a/source/common/chromium_url/BUILD b/source/common/chromium_url/BUILD
diff --git a/source/common/chromium_url/LICENSE b/source/common/chromium_url/LICENSE
diff --git a/source/common/chromium_url/README.md b/source/common/chromium_url/README.md
diff --git a/source/common/chromium_url/envoy_shim.h b/source/common/chromium_url/envoy_shim.h
diff --git a/source/common/chromium_url/url_canon.cc b/source/common/chromium_url/url_canon.cc
diff --git a/source/common/chromium_url/url_canon.h b/source/common/chromium_url/url_canon.h