Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: docker push/tag script cleanups #10716

Closed
mattklein123 opened this issue Apr 9, 2020 · 1 comment · Fixed by #10729
Closed

build: docker push/tag script cleanups #10716

mattklein123 opened this issue Apr 9, 2020 · 1 comment · Fixed by #10729
Assignees
@mattklein123
Labels
area/build help wanted Needs help!
Milestone
1.15.0

Comments

@mattklein123
Copy link
Member

  1. Remove references to CircleCI env variables.
  2. Split the logic between dev builds and tag builds. Each type should independently build the docker images, push, and tag their respective images, vs always pushing to dev first. This will fix Don't update envoy-dev:latest on security fix branch pushes #6595 also.
@mattklein123 mattklein123 added this to the 1.15.0 milestone Apr 9, 2020
@mattklein123
Copy link
Member Author

cc @lizan

@mattklein123 mattklein123 mentioned this issue Apr 9, 2020
Closed
@mattklein123 mattklein123 self-assigned this Apr 9, 2020
mattklein123 added a commit that referenced this issue Apr 9, 2020
@mattklein123
build: refine docker image CI process
1f8c4cd 
Fixes #10716

Signed-off-by: Matt Klein <[email protected]>
@mattklein123 mattklein123 mentioned this issue Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattklein123 mattklein123

Labels
area/build help wanted Needs help!
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

build: refine docker image CI process envoyproxy/envoy
1 participant
@mattklein123