Adding an HTTP/2 integration fuzzer #10321

adisuissa · 2020-03-10T20:08:37Z

Adding an HTTP/2 integration fuzzer that checks different kind of frames handling in both Downstream and Upstream

Signed-off-by: Adi Suissa-Peleg [email protected]

Description: A new fuzzer to test the HTTP/2.0 integration. At the moment it is slow, and should be improved.
Risk Level: Low - a new test
Testing: It is a new fuzz test

…mes handling in both Downstream and Upstream Signed-off-by: Adi Suissa-Peleg <[email protected]>

adisuissa · 2020-03-10T20:09:54Z

cc @asraa @htuch

htuch

Thanks for adding this @adisuissa, it's great to have e2e coverage of H2 happening. A few comments below, I think mostly if we can get a future proof data model (see enum vs. oneof) then we can grow this even further over time.
/wait

test/integration/h2_capture_fuzz.proto

test/integration/h2_fuzz.h

test/integration/h2_fuzz.cc

asraa

This is great :) Thank you for taking this on!

test/integration/h2_capture_fuzz.proto

test/integration/h2_fuzz.cc

stale · 2020-03-18T17:46:55Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

… for each type of frame in the proto file, and adding their possible inner fields Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch

Looks good, just a few more comments, I think this is ready to ship once we figure out the timeout issue.
/wait

test/integration/h2_capture_fuzz.proto

test/integration/h2_capture_fuzz_test.cc

test/integration/h2_fuzz.cc

test/integration/h2_fuzz.h

Signed-off-by: Adi Suissa-Peleg <[email protected]>

test/integration/h2_fuzz.cc

test/integration/h2_fuzz.h

test/integration/h2_capture_fuzz.proto

stale · 2020-04-02T14:15:26Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale · 2020-04-09T14:52:46Z

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch

Looks good, mostly style nits.
/wait

test/integration/h2_capture_fuzz.proto

test/common/http/http2/http2_frame.cc

test/integration/h2_fuzz.cc

test/integration/h2_fuzz.h

asraa · 2020-05-20T15:44:39Z

test/integration/h2_capture_fuzz.proto

+message H2TestFrame {
+  // These values map to the frame creation methods in:
+  // test/common/http/http2/http2_frame.h
+  oneof frame_type {


This is awesome, I'm excited to see metadata frames to this later. @AndresGuedez

Sure. Haven't found a METADATA frame in the RFC, but would be glad to add it if there's a spec.

Signed-off-by: Adi Suissa-Peleg <[email protected]>

adisuissa · 2020-06-04T14:55:51Z

@htuch Please take a look, and let me know if there are other things that should be added/modified

htuch

LGTM modulo a few final minor comments.
/wait

test/common/http/http2/http2_frame.cc

htuch · 2020-06-04T22:42:59Z

test/integration/h2_capture_fuzz.proto

+// an additional zero length header (making this a malformed request)
+message H2FrameMalformedRequestWithZerolenHeader {
+  uint32 stream_index = 1;
+  bytes host = 2;


How come these are bytes and not string?

test/integration/h2_fuzz.cc

Signed-off-by: Adi Suissa-Peleg <[email protected]>

adisuissa · 2020-06-05T14:35:54Z

@htuch I've addressed the latest comments, please take a look. Thanks!

Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch

LGTM, thanks!

Adding an HTTP/2 integration fuzzer that checks different kind of frames handling in both Downstream and Upstream Risk Level: Low - a new test Testing: It is a new fuzz test Signed-off-by: Adi Suissa-Peleg <[email protected]>

Adding an HTTP/2 integration fuzzer that checks different kind of frames handling in both Downstream and Upstream Risk Level: Low - a new test Testing: It is a new fuzz test Signed-off-by: Adi Suissa-Peleg <[email protected]> Signed-off-by: yashwant121 <[email protected]>

Adding an HTTP/2 integration fuzzer that checks different kind of fra…

48b8f1a

…mes handling in both Downstream and Upstream Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch suggested changes Mar 10, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label Mar 10, 2020

htuch assigned htuch and asraa Mar 10, 2020

htuch requested a review from asraa March 10, 2020 22:23

asraa reviewed Mar 11, 2020

View reviewed changes

test/integration/h2_capture_fuzz.proto Outdated Show resolved Hide resolved

test/integration/h2_fuzz.cc Outdated Show resolved Hide resolved

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 18, 2020

Changing h2 integration fuzz test by specifically describing messages…

14bb677

… for each type of frame in the proto file, and adding their possible inner fields Signed-off-by: Adi Suissa-Peleg <[email protected]>

repokitteh-read-only bot removed the waiting label Mar 25, 2020

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Mar 25, 2020

htuch suggested changes Mar 25, 2020

View reviewed changes

test/integration/h2_capture_fuzz.proto Outdated Show resolved Hide resolved

test/integration/h2_capture_fuzz_test.cc Show resolved Hide resolved

test/integration/h2_fuzz.cc Outdated Show resolved Hide resolved

test/integration/h2_fuzz.h Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label Mar 25, 2020

Actually using direct response, and adding some comments

43e0aab

Signed-off-by: Adi Suissa-Peleg <[email protected]>

repokitteh-read-only bot removed the waiting label Mar 26, 2020

htuch reviewed Mar 26, 2020

View reviewed changes

test/integration/h2_fuzz.cc Outdated Show resolved Hide resolved

test/integration/h2_fuzz.h Outdated Show resolved Hide resolved

test/integration/h2_capture_fuzz.proto Outdated Show resolved Hide resolved

test/integration/h2_capture_fuzz.proto Outdated Show resolved Hide resolved

stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 2, 2020

stale bot closed this Apr 9, 2020

adisuissa added 3 commits May 5, 2020 10:08

Adding support for push-promise, go-away and reset-stream messages

7e6c26a

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

9bfd212

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Fixing format

6fbe9ae

Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch reopened this May 18, 2020

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 18, 2020

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

3948260

Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch suggested changes May 20, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label May 20, 2020

asraa reviewed May 20, 2020

View reviewed changes

adisuissa added 3 commits May 26, 2020 09:04

Changing enums in proto, and making headers fields repeatable

837be73

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

8344264

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Adding persistent mode

bf39cf7

Signed-off-by: Adi Suissa-Peleg <[email protected]>

repokitteh-read-only bot removed the waiting label May 26, 2020

adisuissa added 5 commits May 26, 2020 11:29

Fixing the timeout value

8e330f8

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Fixing clang-tidy

4e811ef

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

fec3ebc

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Adding support for malformed header

0cfbac5

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

38bf2ff

Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch suggested changes Jun 4, 2020

View reviewed changes

repokitteh-read-only bot added the waiting label Jun 4, 2020

adisuissa added 3 commits June 5, 2020 10:18

Addressing comments

04814c0

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

9e3e919

Signed-off-by: Adi Suissa-Peleg <[email protected]>

fixing code format

dcb3b62

Signed-off-by: Adi Suissa-Peleg <[email protected]>

repokitteh-read-only bot removed the waiting label Jun 5, 2020

adisuissa added 2 commits June 6, 2020 22:56

Addressing comments

34e60cb

Signed-off-by: Adi Suissa-Peleg <[email protected]>

Merge remote-tracking branch 'upstream/master' into h2_capture_fuzz_test

e481d8a

Signed-off-by: Adi Suissa-Peleg <[email protected]>

htuch approved these changes Jun 7, 2020

View reviewed changes

htuch merged commit 5dfa0f5 into envoyproxy:master Jun 7, 2020

adisuissa mentioned this pull request Jul 29, 2020

[http] bugfix where error details are overridden #12353

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding an HTTP/2 integration fuzzer #10321

Adding an HTTP/2 integration fuzzer #10321

adisuissa commented Mar 10, 2020

adisuissa commented Mar 10, 2020

htuch left a comment

asraa left a comment

stale bot commented Mar 18, 2020

htuch left a comment

stale bot commented Apr 2, 2020

stale bot commented Apr 9, 2020

htuch left a comment

asraa May 20, 2020

adisuissa May 26, 2020

adisuissa commented Jun 4, 2020

htuch left a comment

htuch Jun 4, 2020

adisuissa commented Jun 5, 2020

htuch left a comment

Adding an HTTP/2 integration fuzzer #10321

Adding an HTTP/2 integration fuzzer #10321

Conversation

adisuissa commented Mar 10, 2020

adisuissa commented Mar 10, 2020

htuch left a comment

Choose a reason for hiding this comment

asraa left a comment

Choose a reason for hiding this comment

stale bot commented Mar 18, 2020

htuch left a comment

Choose a reason for hiding this comment

stale bot commented Apr 2, 2020

stale bot commented Apr 9, 2020

htuch left a comment

Choose a reason for hiding this comment

asraa May 20, 2020

Choose a reason for hiding this comment

adisuissa May 26, 2020

Choose a reason for hiding this comment

adisuissa commented Jun 4, 2020

htuch left a comment

Choose a reason for hiding this comment

htuch Jun 4, 2020

Choose a reason for hiding this comment

adisuissa commented Jun 5, 2020

htuch left a comment

Choose a reason for hiding this comment