Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: throw exception in debug mode that condition is always true when fractionalPercent numerator > denominator #12068

Merged
merged 17 commits into from
Aug 13, 2020
Merged

runtime: throw exception in debug mode that condition is always true when fractionalPercent numerator > denominator #12068

merged 17 commits into from
Aug 13, 2020

Commits on Jul 14, 2020

  1. [runtime] debug log that condition is always true when fractionalPerc… 

    …ent numerator > denominator

Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    1b31cad View commit details
    Browse the repository at this point in the history

  2. Fix format 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    472b32c View commit details
    Browse the repository at this point in the history

  3. Exclude debug log from code coverage 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    2108e16 View commit details
    Browse the repository at this point in the history

  4. Address review feedback: throw expection / add unittest 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    c0db266 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Remove "warning" from exception message 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    1d49bda View commit details
    Browse the repository at this point in the history

  2. Merge with upstream master 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    ddca74d View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Merge upstream/master 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    0442492 View commit details
    Browse the repository at this point in the history

  2. Assert for exception only in debug mode 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    e828795 View commit details
    Browse the repository at this point in the history

  3. brint bazelversion back 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    628dbd3 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. call featureEnabled() on release test config. 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6a1408d View commit details
    Browse the repository at this point in the history

  2. Merge with upstream/master 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    54290b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Merge with master 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7824bb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Switch back to debug log instead of expection 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    bf4b498 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into add_debug_message… 

    …_for_wrong_runtime_value

Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    a9453ec View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Fix format 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    140db72 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Merge remote-tracking branch 'upstream/master' into add_debug_message… 

    …_for_wrong_runtime_value

Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    382770b View commit details
    Browse the repository at this point in the history

  2. Assert for log message 

    Signed-off-by: Konstantin Belyalov <[email protected]>
    @belyalov
    belyalov committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    29e13b2 View commit details
    Browse the repository at this point in the history