router: add envoy-ratelimited retry policy #12201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowp
suggested changes
Jul 21, 2020
| @@ -290,9 +293,9 @@ RetryStatus RetryStateImpl::shouldHedgeRetryPerTryTimeout(DoRetryCallback callba | |||
| } | |||
|
|
|||
| bool RetryStateImpl::wouldRetryFromHeaders(const Http::ResponseHeaderMap& response_headers) { | |||
| // We never retry if the request is rate limited. | |||
| // We retry our own rate limited requests only when the envoy-ratelimited policy is in effect. | |||
There was a problem hiding this comment.
"Our own" implies to me that this envoy instance rate limited the request, but its likely going to be another Envoy instance
There was a problem hiding this comment.
Yes, that's a good point. I'll rephrase this to make it clear we're talking about an upstream envoy.
Adds new retry policy envoy-ratelimited that retries responses containing the header x-envoy-ratelimited. Signed-off-by: Martin Matusiak <[email protected]>
Signed-off-by: Martin Matusiak <[email protected]>
Signed-off-by: Martin Matusiak <[email protected]>
numerodix
force-pushed
the
retry-ratelimited-policy
branch
from
4d4b1ee
to
b1f12c2
Compare
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
Adds new retry policy envoy-ratelimited that retries responses containing the header x-envoy-ratelimited. Signed-off-by: Martin Matusiak <[email protected]> Signed-off-by: Kevin Baichoo <[email protected]>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Adds new retry policy envoy-ratelimited that retries responses containing the header x-envoy-ratelimited. Signed-off-by: Martin Matusiak <[email protected]> Signed-off-by: chaoqinli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new retry policy that retries a request if the response contains the header
x-envoy-ratelimited.This is PR (1/2) that addresses issue #12200. See also the design document: https://docs.google.com/document/d/1NSzrx3-KsAFs0ObaLQZUVIt9O4PZv3mXi3Lm7LNzmZE/edit?usp=sharing
Signed-off-by: Martin Matusiak [email protected]
Risk Level: Low
Testing: New unit test added.
Docs Changes: added
Release Notes: added