Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hds: group endpoint health response by cluster and locality #12452

Merged
merged 56 commits into from
Aug 18, 2020
Merged

hds: group endpoint health response by cluster and locality #12452

merged 56 commits into from
Aug 18, 2020

Commits on Jul 17, 2020

  1. add backwards-compatible hds protos to better group endpoint health info 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    4a5e7c5 View commit details
    Browse the repository at this point in the history

  2. formatting fixes for hds protos 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    39ffd06 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. get correct Locality field location 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    0275293 View commit details
    Browse the repository at this point in the history

  2. regenerate api shadow and v4alpha protos 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    980a8e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. retain locality information in cluster config 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b0287eb View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. update tests to include locality, attempt locality pulling on respons… 

    …e level

Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    89f3937 View commit details
    Browse the repository at this point in the history

  2. update comments to hide unimplemented, mark future deprecation 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    834f84b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hds_proto_rework' into hds_proto_rework_impl

    @drewsortega
    drewsortega committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    5ef7776 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Merge branch 'master' into hds_proto_rework_impl

    @drewsortega
    drewsortega committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    8baaa1d View commit details
    Browse the repository at this point in the history

  2. formatting fixes 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    0a1c3f7 View commit details
    Browse the repository at this point in the history

  3. formatting fix 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    2170fde View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. fix endpoint parsing in HdsCluster by using cluster_ member object ov… 

    …er cluster param

Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    3d59d43 View commit details
    Browse the repository at this point in the history

  2. fill out cluster_endpoints_health proto on response gen 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    206510e View commit details
    Browse the repository at this point in the history

  3. use MessageUtil::hash for flat_hash_map construction 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    5897d0e View commit details
    Browse the repository at this point in the history

  4. use MergeFrom to copy Locality into Cluster constructor 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    4f8d0e2 View commit details
    Browse the repository at this point in the history

  5. use Built-in proto hashing for HashMap, remove redundant Locality store 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7695766 View commit details
    Browse the repository at this point in the history

  6. revert whitespace change 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    81dbac4 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. compare locality differences on host iteration instead of hash table 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    6b5a374 View commit details
    Browse the repository at this point in the history

  2. remove not needed import 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    4f6680e View commit details
    Browse the repository at this point in the history

  3. undo extra comment change 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    a215f1b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. add complex hds test specifier builder with many cluster-loc-ends 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    5f38b88 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. change hds test to use loops, add hds cluster name getter 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    f90e6b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. get working unit test with failing destructor 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    2c27e93 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. fix mock connections for endpoints to not be shared 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    b9cada9 View commit details
    Browse the repository at this point in the history

  2. use proper name field from info_ by mocking prod impl on call 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    3ae54b2 View commit details
    Browse the repository at this point in the history

  3. remove underscores from local vars, remove not needed EXPECT_CALLs 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    7ed5ca2 View commit details
    Browse the repository at this point in the history

  4. change existing hds intg tests to use new proto construction 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    e387f7f View commit details
    Browse the repository at this point in the history

  5. remove hidden comment and add deprecate mentioned by hds protos comments 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    bd829dc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into hds_proto_rework_impl_flat

    @drewsortega
    drewsortega committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    bb686c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. upgrade hds intg tests to check for correct updated proto layouts 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    9520832 View commit details
    Browse the repository at this point in the history

  2. add final comments, fix some style issues 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    9fccebb View commit details
    Browse the repository at this point in the history

  3. Minor testing and comment changes as a response to PR feedback 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    132655a View commit details
    Browse the repository at this point in the history

  4. Update current version history to reflect changes and deprecation. 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    c9c1336 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. update hds intg tests, use temp vars in field checks, better loops 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    979049d View commit details
    Browse the repository at this point in the history

  2. hds_test changes, improving readability with temp vars and absl strcat 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    c256c10 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. update hds intg test flaky wait loops to ensure health checks completed 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    93b5a85 View commit details
    Browse the repository at this point in the history

  2. add TODO comment to transition hds protos to v4 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    31cd01c View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. move ASSERT statements out of helper functions in hds intg tests 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    04dab14 View commit details
    Browse the repository at this point in the history

  2. fix clang-tidy issues 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    56d48d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Merge branch 'master' into hds_proto_rework_impl_flat

    @drewsortega
    drewsortega committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f38b5ba View commit details
    Browse the repository at this point in the history

  2. Use unique_ptr in specifier construction, use specific numeric types 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    33a10d4 View commit details
    Browse the repository at this point in the history

  3. More integer type fixes. 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b9a494e View commit details
    Browse the repository at this point in the history

  4. Use a hosts_by_locality to keep groups by locality in priority set 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d36406c View commit details
    Browse the repository at this point in the history

  5. Kick CI 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f9ab70e View commit details
    Browse the repository at this point in the history

  6. fix variable casing, fix shared pointer assignment, optimizations 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d371378 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. fix emplace vs push 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    5b7c703 View commit details
    Browse the repository at this point in the history

  2. whitespace fixes 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    f72761b View commit details
    Browse the repository at this point in the history

  3. Kick CI 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    408bdb7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into hds_proto_rework_impl_flat, Kick CI

    @drewsortega
    drewsortega committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    ffa4fee View commit details
    Browse the repository at this point in the history

  5. Kick CI 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    58d0695 View commit details
    Browse the repository at this point in the history

  6. Kick CI 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    a5eb281 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Merge branch 'master' into hds_proto_rework_impl_flat

    @drewsortega
    drewsortega committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    0ea3f1a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2020

  1. Merge branch 'master' into hds_proto_rework_impl_flat

    @drewsortega
    drewsortega committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    c0ceb90 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Kick CI 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    4e9ccec View commit details
    Browse the repository at this point in the history

  2. Kick CI 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    2c300ae View commit details
    Browse the repository at this point in the history

  3. replace if-else chain with cleaner switch block 

    Signed-off-by: Drew S. Ortega <[email protected]>
    @drewsortega
    drewsortega committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    4f192d4 View commit details
    Browse the repository at this point in the history