Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp_proxy: use dynamicMetadata() from StreamInfo for load balancing #12595

Merged
merged 5 commits into from
Aug 21, 2020

Conversation

ggreenway
Copy link
Contributor

Commit Message:
This allows earlier network filters to set dynamicMetadata() on
the connection StreamInfo to influence load balancing (such as subset_lb).

Signed-off-by: Greg Greenway [email protected]

Risk Level: Low
Testing: Added UT and integration tests
Docs Changes: Added
Release Notes: Added

This allows earlier network filters to set dynamicMetadata() on
the connection StreamInfo to influence load balancing (such as subset_lb).

Signed-off-by: Greg Greenway <[email protected]>
Signed-off-by: Greg Greenway <[email protected]>
Signed-off-by: Greg Greenway <[email protected]>
@envoyproxy envoyproxy deleted a comment from azure-pipelines bot Aug 12, 2020
@ggreenway
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #12595 (comment) was created by @ggreenway.

see: more, trace.

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks pretty good.

test/common/tcp_proxy/tcp_proxy_test.cc Outdated Show resolved Hide resolved
test/common/tcp_proxy/tcp_proxy_test.cc Outdated Show resolved Hide resolved
test/integration/tcp_proxy_integration_test.cc Outdated Show resolved Hide resolved
test/integration/tcp_proxy_integration_test.cc Outdated Show resolved Hide resolved
@ggreenway
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines, to retry CircleCI checks, use /retest-circle.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #12595 (comment) was created by @ggreenway.

see: more, trace.

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ggreenway ggreenway merged commit 60de12b into envoyproxy:master Aug 21, 2020
lavignes added a commit to lavignes/envoy that referenced this pull request Aug 24, 2020
* envoy/master: (90 commits)
  cleanup: use structured binding (envoyproxy#12791)
  docs: fix header name for retries in gRPC services (envoyproxy#12790)
  docs: clarify meaning of HeaderValueOption.append (envoyproxy#12792)
  doc: clarify handling of duplicate xDS resource names (envoyproxy#12756)
  Dependencies: build updates. (envoyproxy#12786)
  Ratelimit: Add optional descriptor key to generic_key action (envoyproxy#12734)
  test: refactor header inclusion to speed up building (for test/mocks/upstream:upstream_mocks)  (envoyproxy#12407)
  docs: Fix omitted word (envoyproxy#12782)
  ci: avoid uploading dwp as separate artifact (envoyproxy#12777)
  doc: Fix small typos (envoyproxy#12769)
  fix cache factory category (envoyproxy#12765)
  docs: fix typo v1.15.0.rst (envoyproxy#12680)
  Add clang-cl RBE toolchain for Windows (envoyproxy#12776)
  fuzz: add router fuzz proto (envoyproxy#12727)
  header: New HeaderMatcher and StringMatcher type - Contains (envoyproxy#12623)
  tcp_proxy: use dynamicMetadata() from StreamInfo for load balancing (envoyproxy#12595)
  network: add io handle recv function for http inspector (envoyproxy#12736)
  jwt_authn: supports jwt payload without "iss" field (envoyproxy#12744)
  Add support for nested JSON format in json logging mode (envoyproxy#12602)
  http: fixing a fuzz flake by setting details on connection teardown (envoyproxy#12737)
  ...

Signed-off-by: Scott LaVigne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants