Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests: re-enable set_node_on_first_message_only #14270

Merged
merged 3 commits into from
Dec 16, 2020
Merged

integration tests: re-enable set_node_on_first_message_only #14270

merged 3 commits into from
Dec 16, 2020

Conversation

tbarrella
Copy link
Contributor

@tbarrella tbarrella commented Dec 3, 2020

Commit Message:

integration tests: re-enable set_node_on_first_message_only

A series of changes and reverts caused this to seemingly unintentionally stay disabled

Signed-off-by: Taylor Barrella [email protected]

Additional Description:
Risk Level: Low
Testing: Integration tests
Docs Changes: N/A
Release Notes: N/A

A series of changes and reverts caused this to seemingly unintentionally
stay disabled

Signed-off-by: Taylor Barrella <[email protected]>
@tbarrella
Copy link
Contributor Author

@snowp do you have a chance to review this?

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks reasonable to me, just some questions around the test structure

test/integration/ads_integration_test.cc Outdated Show resolved Hide resolved
test/integration/ads_integration_test.cc Outdated Show resolved Hide resolved
Signed-off-by: Taylor Barrella <[email protected]>
@tbarrella tbarrella changed the title Re-enable set_node_on_first_message_only in integration tests integration tests: re-enable set_node_on_first_message_only Dec 14, 2020
@tbarrella
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14270 (comment) was created by @tbarrella.

see: more, trace.

@tbarrella
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14270 (comment) was created by @tbarrella.

see: more, trace.

@tbarrella tbarrella requested a review from snowp December 15, 2020 20:46
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snowp snowp merged commit 95b7ef2 into envoyproxy:master Dec 16, 2020
@tbarrella tbarrella deleted the test-set-node branch December 16, 2020 18:17
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 16, 2020
* master: (49 commits)
  sds: allow multiple init managers share sds target (envoyproxy#14357)
  [http] Remove legacy codecs (envoyproxy#14381)
  http2: Add integration tests for METADATA and RST_STREAM frame flood mitigation for upstream servers (envoyproxy#14365)
  test: start dissolving :printers_include rule. (envoyproxy#14429)
  integration tests: re-enable set_node_on_first_message_only (envoyproxy#14270)
  formatter: add a formatter that returns a google::protobuf::Struct rather than a string (envoyproxy#14258)
  ratelimit: support returning custom response bodies for non-OK responses from the external ratelimit service (envoyproxy#14189)
  deps: update protobuf to 3.14 (envoyproxy#14253)
  stream_info: add setResponseCode and update local_reply to take a normal StreamInfo (envoyproxy#14402)
  http: alpn upstream (envoyproxy#13922)
  Moved starttls integration test to test/extensions/transport_sockets/starttls. (envoyproxy#14425)
  generic conn pool: directly use thread local cluster (envoyproxy#14423)
  wasm: add mathetake to CODEOWNERS (envoyproxy#14427)
  wasm: clear route cache when modifying HTTP request headers. (envoyproxy#14318)
  tls: disable TLS inspector injection (envoyproxy#14404)
  aggregate cluster: cleanups (envoyproxy#14411)
  Mark starttls_integration_test flaky on Windows (envoyproxy#14419)
  tcp: improved unit testing (envoyproxy#14415)
  config: making protocol config explicit (envoyproxy#14362)
  wasm: dead code (envoyproxy#14407)
  ...

Signed-off-by: Michael Puncel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants