quiche: Fix crash in Quic listener upon request without authority

[danzh2010]

Signed-off-by: Dan Zhang [email protected]

Commit Message: Fix a recent regression where Quic listener crash while decoding request headers without :authority field.

Risk Level: low, WIP feature.
Testing: added integration test

[moderation]

I think this is related to testing with https://github.com/kazu-yamamoto/h3spec/

Original CID: 67561517f79bac11
handshakeClientConnection: NextVersion Draft29
Original CID: 396a54847c68fd3f
Version: Draft29
Cipher: AES256GCM-SHA384
ALPN: h3-29
Mode: FullHandshake
Local CID: 4e797cace3c212bd
Remote CID: 396a54847c68fd3f
Local SockAddr: [fd7a:115c:a1e0:ab12:4843:cd96:6259:f77d]:56541
Remote SockAddr: [fd7a:115c:a1e0:ab12:4843:cd96:6259:f77d]:4433
readerClient: Network.Socket.recvBuf: does not exist (Connection refused)
sender: Network.Socket.ByteString.sendMany: does not exist (Connection refused)
  MUST send H3_MESSAGE_ERROR if mandatory pseudo-header fields are absent [HTTP/3 4.1.3] FAILED [10]

[2021-03-29 15:30:23.674][458474][debug][quic_stream] [source/common/quic/envoy_quic_server_stream.cc:62] [C4270600207827630722][S0] encodeHeaders (end_stream=false) ':status', '400'                                                                                                                                                                          
'server', 'envoy'                                                                                                                                                               
'date', 'Mon, 29 Mar 2021 22:30:23 GMT'                                                                                                                                         
'content-type', 'text/html'                                                                                                                                                     
'content-length', '122'                                                                                                                                                         
'x-envoy-upstream-service-time', '387'                                                                                                                                          
.                                                                                                                                                                               
[2021-03-29 15:30:23.674][458474][debug][client] [source/common/http/codec_client.cc:122] [C0] response complete                                                                
[2021-03-29 15:30:23.674][458474][debug][pool] [source/common/conn_pool/conn_pool_base.cc:199] [C0] destroying stream: 0 remaining                                              
[2021-03-29 15:30:23.674][458474][debug][quic_stream] [source/common/quic/envoy_quic_server_stream.cc:87] [C4270600207827630722][S0] encodeData (end_stream=true) of 122 bytes. 
[2021-03-29 15:30:23.675][458474][debug][http2] [source/common/http/http2/codec_impl.cc:999] [C0] stream closed: 0                                                              
[2021-03-29 15:30:23.903][458474][debug][http] [source/common/http/conn_manager_impl.cc:259] [C16503042738206918425] new stream                                                 
[2021-03-29 15:30:23.903][458474][debug][quic_stream] [source/common/quic/envoy_quic_server_stream.cc:160] [C16503042738206918425][S0] Received headers: { :method=GET, :scheme=https, :path=/, }.                                                                                                                                                              
fish: "~/Library/envoy/envoy --concurr…" terminated by signal SIGSEGV (Address boundary error)            

[alyssawilk]

Nice!

Want to set details here or wait and add them all at once?

[danzh2010]

I will set invalid http header response code in #15753

[danzh2010]

/assign @mattklein123

[moderation]

@danzh2010 @alyssawilk I can confirm the fix works with no crashes using h3spec 0.1.6. Thanks