transport_sockets: fixing alpn for wrapped sockets #19281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
ggreenway
requested changes
Dec 14, 2021
| public: | ||
| PassthroughFactory(Network::TransportSocketFactoryPtr&& transport_socket_factory) | ||
| : transport_socket_factory_(std::move(transport_socket_factory)) { | ||
| ASSERT(transport_socket_factory_.get()); |
There was a problem hiding this comment.
nit: ASSERT(transport_socket_factory_ != nullptr) is slightly clearer.
| } | ||
|
|
||
| protected: | ||
| // The wrapped factory |
Signed-off-by: Alyssa Wilk <[email protected]>
ggreenway
previously approved these changes
Dec 14, 2021
Signed-off-by: Alyssa Wilk <[email protected]>
ggreenway
approved these changes
Dec 14, 2021
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Creating a passthrough factory for consistent handling of wrapped characteristics for proxy_proto, tap, and tcp_stats socket factories. Risk Level: low Testing: new unit testing Docs Changes: n/a Release Notes: inline Part of envoyproxy#19149 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Josh Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a passthrough factory for consistent handling of wrapped characteristics for proxy_proto, tap, and tcp_stats socket factories.
Risk Level: low
Testing: new unit testing
Docs Changes: n/a
Release Notes: inline
Part of #19149