alpn: fixing config validation for socket matchers #19284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
ggreenway
previously approved these changes
Dec 14, 2021
Signed-off-by: Alyssa Wilk <[email protected]>
ggreenway
approved these changes
Dec 15, 2021
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
Making sure that socket matchers on alpn-required clusters support ALPN. Risk Level: Medium Testing: new unit tests Docs Changes: n/a Release Notes: inline Runtime guard: envoy.reloadable_features.correctly_validate_alpn Part of envoyproxy#19149 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Josh Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure that socket matchers on alpn-required clusters support ALPN.
Risk Level: Medium
Testing: new unit tests
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.correctly_validate_alpn
Part of #19149