Full Set Of Changes For Pattern Match and Rewrite #22207

silverstar194 · 2022-07-14T15:53:58Z

Commit Message:
Full Set Of Changes For Pattern Match and Rewrite

Additional Description:
This PR will implement issue detailed here and described below: #7763

Match Patterns and Templates

Wildcard support based on match patterns and templates.

A match pattern matches an incoming URL path.
Match patterns support glob operators to match URL text and variable definitions to bind matched text to names.
Template patterns are used to re-write URLs.
Template patterns build new URLs and may reference variables bound by a match pattern.

Match Examples

/**.m3u8 would match /foo.m3u8 and /foo/bar.m3u8.
/{dir_name}/*.ts would match /example/file.ts and bind dir_name="example" for a later template match to use.
/{dir_name}/**.ts would match /example/path/file.ts and bind dir_name="example" for a later template match to use. This would also match /example/.ts, which may or may not be a desired behavior.
/{path=v1/*}/{file=*.ts} would match /v1/example/movie.ts (binding path="v1/example" and file="movie"), but would not match /v0/example/movie.ts.

See post for full details and example:
#7763 (comment)

Risk Level:
Testing:
Unit tests. Both both internal matching/rewrite library and config/data plane changes.

Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

repokitteh-read-only · 2022-07-14T15:54:02Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #22207 was opened by silverstar194.

see: more, trace.

repokitteh-read-only · 2022-07-14T15:54:07Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #22207 was opened by silverstar194.

see: more, trace.

Signed-off-by: silverstar195 <[email protected]>

…ite-extention-lib Signed-off-by: silverstar195 <[email protected]>

Signed-off-by: silverstar195 <[email protected]>

…er-filter-matching-lib-control-plane # Conflicts: # envoy/router/BUILD # source/extensions/extensions_build_config.bzl # source/extensions/extensions_metadata.yaml # tools/extensions/extensions_schema.yaml Signed-off-by: silverstar195 <[email protected]>

Signed-off-by: silverstar195 <[email protected]>

…ite-extention-lib Signed-off-by: silverstar195 <[email protected]>

Signed-off-by: silverstar195 <[email protected]>

…ter-filter-matching-lib-control-plane Signed-off-by: silverstar195 <[email protected]>

source/common/http/async_client_impl.cc

source/common/http/async_client_impl.h

tools/spelling/spelling_dictionary.txt

test/per_file_coverage.sh

test/mocks/router/mocks.h

Signed-off-by: silverstar195 <[email protected]>

silverstar194 · 2022-09-09T14:50:22Z

/retest

repokitteh-read-only · 2022-09-09T14:50:27Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22207 (comment) was created by @silverstar194.

see: more, trace.

silverstar194 · 2022-09-09T14:54:11Z

/retest

repokitteh-read-only · 2022-09-09T14:54:15Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22207 (comment) was created by @silverstar194.

see: more, trace.

RyanTheOptimist

I think we definitely need to sort out the test coverage issues, but we're probably ready for @zuercher to take a cross-company review.

tools/spelling/spelling_dictionary.txt

test/per_file_coverage.sh

Signed-off-by: silverstar195 <[email protected]>

silverstar194 · 2022-09-12T13:36:37Z

/retest

repokitteh-read-only · 2022-09-12T13:36:46Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22207 (comment) was created by @silverstar194.

see: more, trace.

Signed-off-by: silverstar195 <[email protected]>

silverstar194 · 2022-09-13T12:13:58Z

@zuercher Could you take a look?

zuercher

Thanks! I think this looks good.

RyanTheOptimist · 2022-09-14T04:27:24Z

@htuch can you give this an API review?

htuch

/lgtm api

repokitteh-read-only bot added the api label Jul 14, 2022

repokitteh-read-only bot assigned htuch Jul 14, 2022

silverstar194 added 26 commits July 14, 2022 19:00

Isolate pattern_template extension and rename to pattern_template

a6d8c43

Signed-off-by: silverstar195 <[email protected]>

Document change

9aa0d4a

Signed-off-by: silverstar195 <[email protected]>

Merge branch 'main' into rewrite-extention-lib

2e88760

Document change

316ff04

Signed-off-by: silverstar195 <[email protected]>

Merge remote-tracking branch 'origin/rewrite-extention-lib' into rewr…

04c762f

…ite-extention-lib Signed-off-by: silverstar195 <[email protected]>

Style and lint fixes

f7670a1

Signed-off-by: silverstar195 <[email protected]>

Document change

029e9ee

Signed-off-by: silverstar195 <[email protected]>

Adding TypedExtensionConfig

e14d4d6

Signed-off-by: silverstar195 <[email protected]>

Incremental Change

4846099

Signed-off-by: silverstar195 <[email protected]>

Merge branch 'main' into rewrite-extention-lib

1405a3c

Added import

e3cb859

Signed-off-by: silverstar195 <[email protected]>

Merge remote-tracking branch 'origin/rewrite-extention-lib' into rewr…

9314a34

…ite-extention-lib Signed-off-by: silverstar195 <[email protected]>

Style and formatting

db9aa98

Signed-off-by: silverstar195 <[email protected]>

Spelling

03fc99b

Signed-off-by: silverstar195 <[email protected]>

Added import

b4a840b

Signed-off-by: silverstar195 <[email protected]>

Style

cf26d41

Signed-off-by: silverstar195 <[email protected]>

Style

f493c54

Signed-off-by: silverstar195 <[email protected]>

Added string words

3543c89

Signed-off-by: silverstar195 <[email protected]>

Change extension name

910f0a1

Signed-off-by: silverstar195 <[email protected]>

Change import

75a8e66

Signed-off-by: silverstar195 <[email protected]>

Changed extension name

be8991e

Signed-off-by: silverstar195 <[email protected]>

Added import

c6b511d

Signed-off-by: silverstar195 <[email protected]>

Changed title

7c4ec0a

Signed-off-by: silverstar195 <[email protected]>

Separate extension into two

5ee9933

Signed-off-by: silverstar195 <[email protected]>

Merge remote-tracking branch 'origin/rewrite-extention-duel' into rou…

2466c3d

…ter-filter-matching-lib-control-plane Signed-off-by: silverstar195 <[email protected]>

silverstar194 requested review from RyanTheOptimist and zuercher and removed request for RyanTheOptimist and zuercher September 9, 2022 13:51

RyanTheOptimist reviewed Sep 9, 2022

View reviewed changes

silverstar194 added 2 commits September 9, 2022 14:23

Format

a28f4dd

Signed-off-by: silverstar195 <[email protected]>

Format

e90c05f

Signed-off-by: silverstar195 <[email protected]>

silverstar194 requested a review from RyanTheOptimist September 9, 2022 14:48

RyanTheOptimist reviewed Sep 9, 2022

View reviewed changes

tools/spelling/spelling_dictionary.txt Outdated Show resolved Hide resolved

test/per_file_coverage.sh Outdated Show resolved Hide resolved

silverstar194 added 3 commits September 9, 2022 20:04

Changed dictionary

2abde45

Signed-off-by: silverstar195 <[email protected]>

Added tests

c7c0cf3

Signed-off-by: silverstar195 <[email protected]>

Format

3d14860

Signed-off-by: silverstar195 <[email protected]>

Removed reduced coverage

7250108

Signed-off-by: silverstar195 <[email protected]>

silverstar194 requested review from RyanTheOptimist and zuercher and removed request for RyanTheOptimist September 12, 2022 15:54

RyanTheOptimist approved these changes Sep 12, 2022

View reviewed changes

zuercher approved these changes Sep 14, 2022

View reviewed changes

htuch reviewed Sep 14, 2022

View reviewed changes

repokitteh-read-only bot removed the api label Sep 14, 2022

htuch merged commit 8cfc61f into envoyproxy:main Sep 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full Set Of Changes For Pattern Match and Rewrite #22207

Full Set Of Changes For Pattern Match and Rewrite #22207

silverstar194 commented Jul 14, 2022 •

edited

Loading

repokitteh-read-only bot commented Jul 14, 2022

repokitteh-read-only bot commented Jul 14, 2022

silverstar194 commented Sep 9, 2022

repokitteh-read-only bot commented Sep 9, 2022

silverstar194 commented Sep 9, 2022

repokitteh-read-only bot commented Sep 9, 2022

RyanTheOptimist left a comment

silverstar194 commented Sep 12, 2022

repokitteh-read-only bot commented Sep 12, 2022

silverstar194 commented Sep 13, 2022

zuercher left a comment

RyanTheOptimist commented Sep 14, 2022

htuch left a comment

Full Set Of Changes For Pattern Match and Rewrite #22207

Full Set Of Changes For Pattern Match and Rewrite #22207

Conversation

silverstar194 commented Jul 14, 2022 • edited Loading

Match Patterns and Templates

Match Examples

repokitteh-read-only bot commented Jul 14, 2022

repokitteh-read-only bot commented Jul 14, 2022

silverstar194 commented Sep 9, 2022

repokitteh-read-only bot commented Sep 9, 2022

silverstar194 commented Sep 9, 2022

repokitteh-read-only bot commented Sep 9, 2022

RyanTheOptimist left a comment

Choose a reason for hiding this comment

silverstar194 commented Sep 12, 2022

repokitteh-read-only bot commented Sep 12, 2022

silverstar194 commented Sep 13, 2022

zuercher left a comment

Choose a reason for hiding this comment

RyanTheOptimist commented Sep 14, 2022

htuch left a comment

Choose a reason for hiding this comment

silverstar194 commented Jul 14, 2022 •

edited

Loading