Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_proc filter ASSERT at canIterate() when client not sending trailer #28592

Merged
merged 7 commits into from
Jul 27, 2023
Merged

ext_proc filter ASSERT at canIterate() when client not sending trailer #28592

merged 7 commits into from
Jul 27, 2023

Commits on Jul 25, 2023

  1. Support addTrailers() when filter decodeData() at same time return st… 

    …opIteration.

Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4d7af16 View commit details
    Browse the repository at this point in the history

  2. fix format issue 

    Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b65ef87 View commit details
    Browse the repository at this point in the history

  3. making the change specific for ext_proc filter 

    Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b8d5d29 View commit details
    Browse the repository at this point in the history

  4. removing the ext_proc logic to send empty trailer when no such trail… 

    …er from client or server

Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ade4605 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. fixing the tests 

    Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    597b13e View commit details
    Browse the repository at this point in the history

  2. fixing ordering test failure 

    Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6592b67 View commit details
    Browse the repository at this point in the history

  3. fixing tests 

    Signed-off-by: Yanjun Xiang <[email protected]>
    @yanjunxiang-google
    yanjunxiang-google committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f55bbf8 View commit details
    Browse the repository at this point in the history