Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: final tag for release #2862

Merged
merged 2 commits into from
Mar 20, 2018
Merged

docs: final tag for release #2862

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c722eb8
docs: final tag for release
mattklein123 Mar 20, 2018
04aef4e
fix
mattklein123 Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions GOVERNANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,25 @@
wind up with stale docs.
* Do a final check of the [release notes](https://github.com/envoyproxy/data-plane-api/blob/master/docs/root/intro/version_history.rst)
and make any needed corrections.
* Switch the [VERSION](https://github.com/envoyproxy/data-plane-api/blob/master/VERSION) from a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-plane-api VERSION

"dev" variant to a final variant. E.g., "1.6.0-dev" to "1.6.0". Get a review and merge.
* Update the [data-plane-api SHA in Envoy](https://github.com/envoyproxy/envoy/blob/ed312500ec38876446ce8ee70a06f7cda4adc937/bazel/repository_locations.bzl#L79)
to the final release SHA. Get the PR approved and merge.
* **Wait for tests to pass on master.**
* Create a [tagged release](https://github.com/envoyproxy/envoy/releases). The release should
start with "v" and be followed by the version number. E.g., "v1.6.0".
start with "v" and be followed by the version number. E.g., "v1.6.0". **This must match
the [VERSION](https://github.com/envoyproxy/data-plane-api/blob/master/VERSION).**
* Monitor the CircleCI tag build to make sure that the final docker images get pushed along with
the final docs. The final documentation will end up in the
[envoyproxy.github.io repository](https://github.com/envoyproxy/envoyproxy.github.io/tree/master/docs/envoy).
* Contact rdl@ on Slack so that the website can be updated for the new release.
* Craft a witty/uplifting email and send it to all the email aliases including envoy-announce@.
* If possible post on Twitter (either have Matt do it or contact caniszczyk@ on Slack and have the
* If possible post on Twitter (either have Matt do it or contact caniszczyk@ on Slack and have the
Envoy account post).
* Do a new PR to update the [VERSION](https://github.com/envoyproxy/data-plane-api/blob/master/VERSION)
to the next development release. E.g., "1.7.0-dev". At the same time, also add a new empty section
to the [release notes](https://github.com/envoyproxy/data-plane-api/blob/master/docs/root/intro/version_history.rst)
for the following version. E.g., "1.7.0".

## When does a maintainer lose maintainer status

Expand Down
2 changes: 1 addition & 1 deletion bazel/repository_locations.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ REPOSITORY_LOCATIONS = dict(
urls = ["https://github.com/google/protobuf/archive/v3.5.0.tar.gz"],
),
envoy_api = dict(
commit = "056ece6424ad218b70191218360f31a7cbfb398b",
commit = "46198f19e81ed0480ed15415fdc3af1a375daaf7",
remote = "https://github.com/envoyproxy/data-plane-api",
),
grpc_httpjson_transcoding = dict(
Expand Down