Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use absl string append #28959

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

botengyao
Copy link
Member

a += b + c + .. may introduce some unnecessary temp string.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Boteng Yao <[email protected]>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #28959 was opened by botengyao.

see: more, trace.

Signed-off-by: Boteng Yao <[email protected]>
@botengyao botengyao changed the title string: use string append perf: use absl string append Aug 10, 2023
@botengyao botengyao marked this pull request as ready for review August 10, 2023 19:27
@botengyao
Copy link
Member Author

/assign @phlax

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit c1abe8a into envoyproxy:main Aug 11, 2023
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants