ext_proc: send attributes #31090

jbohanon · 2023-11-28T20:57:07Z

Rework of #30781 which was reverted in #31017 due to ASAN fuzzer issues

The ASAN fuzzer issues are unrelated to the net-new code here and will affect any code that calls CEL Parse.

The main differences between this and the original PR:

Refactored out expression/mathching code into separate util classes
Preserve the expr object from which ParsedExpr are built per ext_proc: send attributes #30781 (comment)
Conditionally fuzz the request_attributes and response_attributes fields on non-ASAN fuzzing due to unrelated issue with ASAN fuzzing in CEL parsing per Revert ext_proc: send attributes #30781 #31017 (comment)

Commit Message:
Introduce the ability to send attributes in the External Processing Request
Additional Description:
Risk Level: Low
Testing: Integration tests for request/response attributes

Release Notes: N/A
Platform Specific Features: CEL parsing will not work on Windows

Signed-off-by: Jacob Bohanon <[email protected]>

repokitteh-read-only · 2023-11-28T20:57:12Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #31090 was opened by jbohanon.

see: more, trace.

source/extensions/filters/http/ext_proc/matching_utils.h

Signed-off-by: Jacob Bohanon <[email protected]>

source/extensions/filters/http/ext_proc/ext_proc.h

source/extensions/filters/http/ext_proc/matching_utils.h

Signed-off-by: Jacob Bohanon <[email protected]>

source/extensions/filters/http/ext_proc/matching_utils.cc

Signed-off-by: Jacob Bohanon <[email protected]>

repokitteh-read-only · 2023-11-30T21:12:20Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #31090 was synchronize by jbohanon.

see: more, trace.

Signed-off-by: Jacob Bohanon <[email protected]>

yanjunxiang-google · 2024-01-16T16:30:22Z

source/extensions/filters/http/ext_proc/ext_proc.cc

@@ -221,7 +221,8 @@ void Filter::onDestroy() {
 }

 FilterHeadersStatus Filter::onHeaders(ProcessorState& state,
-                                      Http::RequestOrResponseHeaderMap& headers, bool end_stream) {
+                                      Http::RequestOrResponseHeaderMap& headers, bool end_stream,
+                                      ProtobufWkt::Struct* proto) {


Should proto be passed by reference?

We use nullptr to indicate that attributes are not configured. This is on Line 243

yanjunxiang-google · 2024-01-16T16:33:54Z

/lgtm

repokitteh-read-only · 2024-01-16T16:33:58Z

please specify a single label can be specified

🐱

Caused by: a #31090 (comment) was created by @yanjunxiang-google.

see: more, trace.

Signed-off-by: Jacob Bohanon <[email protected]>

jbohanon · 2024-01-16T18:21:24Z

It appears that the Mobile/Android check is broken on some unrelated toolchain issues

Signed-off-by: Jacob Bohanon <[email protected]>

abeyad · 2024-01-16T18:43:28Z

It appears that the Mobile/Android check is broken on some unrelated toolchain issues

You're right, I'll look into this

Signed-off-by: Jacob Bohanon <[email protected]>

tyxia

LGTM, Thank you for your patience! Nice work

tyxia · 2024-01-17T14:18:25Z

defer to @yanavlasov for final review and merge. PTAL, Thanks

Signed-off-by: Jacob Bohanon <[email protected]>

linsun · 2024-01-19T15:11:50Z

@yanavlasov a friendly ping for final review and merge when you get a chance? Thx!

Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <[email protected]>

* ext_proc: send attributes (envoyproxy#31090) Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <[email protected]> * ext_proc: send and receive dynamic metadata (envoyproxy#30747) Introduce the ability to send dynamic metadata in the External Processing Request. Also implements the API for returning dynamic metadata as part of the External Processing Response. --------- Signed-off-by: Jacob Bohanon <[email protected]> * ext_proc: revise service api for attributes (envoyproxy#32176) --------- Signed-off-by: Jacob Bohanon <[email protected]> --------- Signed-off-by: Jacob Bohanon <[email protected]>

jbohanon added 10 commits November 8, 2023 11:47

extract attributes changes from envoyproxy#29069

87cf9ba

Signed-off-by: Jacob Bohanon <[email protected]>

fix ordering test constructor

45ec23d

Signed-off-by: Jacob Bohanon <[email protected]>

don't do CEL stuff if no attributes are configured

0a9f228

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

6826a1c

Signed-off-by: Jacob Bohanon <[email protected]>

fix variable shadowing

9857119

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

c26d44c

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

db599b9

Signed-off-by: Jacob Bohanon <[email protected]>

refactor matching utils out

a4454be

Signed-off-by: Jacob Bohanon <[email protected]>

refactor matching utils out

34b8fbc

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

d5ce702

Signed-off-by: Jacob Bohanon <[email protected]>

ashishb-solo reviewed Nov 29, 2023

View reviewed changes

source/extensions/filters/http/ext_proc/matching_utils.h Outdated Show resolved Hide resolved

ashishb-solo reviewed Nov 29, 2023

View reviewed changes

source/extensions/filters/http/ext_proc/matching_utils.h Outdated Show resolved Hide resolved

jbohanon added 2 commits November 29, 2023 10:59

fix pointer/references

3631683

Signed-off-by: Jacob Bohanon <[email protected]>

where are my CEL objects going

47c2b46

Signed-off-by: Jacob Bohanon <[email protected]>

jbohanon commented Nov 30, 2023

View reviewed changes

source/extensions/filters/http/ext_proc/ext_proc.h Outdated Show resolved Hide resolved

yuval-k reviewed Nov 30, 2023

View reviewed changes

source/extensions/filters/http/ext_proc/matching_utils.h Outdated Show resolved Hide resolved

jbohanon added 2 commits November 30, 2023 11:16

fix lifetime issue and clean up

86ae01f

Signed-off-by: Jacob Bohanon <[email protected]>

fix runtime feature format

0d8f5d4

Signed-off-by: Jacob Bohanon <[email protected]>

yuval-k reviewed Nov 30, 2023

View reviewed changes

source/extensions/filters/http/ext_proc/matching_utils.cc Outdated Show resolved Hide resolved

jbohanon added 3 commits November 30, 2023 14:22

declare iter as reference

dc692e1

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

8a28f0d

Signed-off-by: Jacob Bohanon <[email protected]>

fix tests and clean up

8d34e78

Signed-off-by: Jacob Bohanon <[email protected]>

repokitteh-read-only bot added the api label Nov 30, 2023

repokitteh-read-only bot assigned wbpcode Nov 30, 2023

jbohanon marked this pull request as ready for review November 30, 2023 21:15

jbohanon requested review from mattklein123, htuch and yanavlasov as code owners November 30, 2023 21:15

jbohanon added 5 commits January 9, 2024 16:33

kick CI

defdd94

Signed-off-by: Jacob Bohanon <[email protected]>

kick CI

c86a731

Signed-off-by: Jacob Bohanon <[email protected]>

kick CI

0b3e715

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

374770f

Signed-off-by: Jacob Bohanon <[email protected]>

revert unwanted local build change

a3e689f

Signed-off-by: Jacob Bohanon <[email protected]>

jbohanon mentioned this pull request Jan 15, 2024

ci/codeql: Fix build target acquisition #31722

Merged

Merge branch 'main' into feature/ext_proc/request-response-attributes

2c716b7

Signed-off-by: Jacob Bohanon <[email protected]>

yanjunxiang-google reviewed Jan 16, 2024

View reviewed changes

jbohanon added 2 commits January 16, 2024 13:14

add skip_on_windows due to recent CEL bump

9948c57

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

7d58055

Signed-off-by: Jacob Bohanon <[email protected]>

fix BUILD

fcaa5af

Signed-off-by: Jacob Bohanon <[email protected]>

skip client build on windows

5fac8a5

Signed-off-by: Jacob Bohanon <[email protected]>

tyxia approved these changes Jan 17, 2024

View reviewed changes

jbohanon added 3 commits January 17, 2024 16:56

MORE SKIP ON WINDOWS

970fb4d

Signed-off-by: Jacob Bohanon <[email protected]>

add filter to windows skip in bazel/repositories.bzl

a43136e

Signed-off-by: Jacob Bohanon <[email protected]>

Merge branch 'main' into feature/ext_proc/request-response-attributes

cfe7006

Signed-off-by: Jacob Bohanon <[email protected]>

yanavlasov approved these changes Jan 24, 2024

View reviewed changes

yanavlasov merged commit 6952f54 into envoyproxy:main Jan 24, 2024
53 of 55 checks passed

This was referenced Jan 25, 2024

ext_proc: allow override metadata without grpc_service #31544

Merged

ext_proc: proto update #32135

Closed

wbpcode mentioned this pull request Feb 5, 2024

ext_proc: revise service api for attributes #32176

Merged

jbohanon added a commit to solo-io/envoy-fork that referenced this pull request Feb 28, 2024

ext_proc: send attributes (envoyproxy#31090)

2deb25e

Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <[email protected]>

jbohanon added a commit to solo-io/envoy-fork that referenced this pull request Mar 1, 2024

ext_proc: send attributes (envoyproxy#31090)

5c630d2

Introduce the ability to send attributes in the External Processing Request --------- Signed-off-by: Jacob Bohanon <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ext_proc: send attributes #31090

ext_proc: send attributes #31090

jbohanon commented Nov 28, 2023 •

edited

Loading

repokitteh-read-only bot commented Nov 28, 2023

repokitteh-read-only bot commented Nov 30, 2023

yanjunxiang-google Jan 16, 2024 •

edited

Loading

jbohanon Jan 16, 2024

yanjunxiang-google commented Jan 16, 2024

repokitteh-read-only bot commented Jan 16, 2024

jbohanon commented Jan 16, 2024

abeyad commented Jan 16, 2024

tyxia left a comment

tyxia commented Jan 17, 2024

linsun commented Jan 19, 2024

ext_proc: send attributes #31090

ext_proc: send attributes #31090

Conversation

jbohanon commented Nov 28, 2023 • edited Loading

repokitteh-read-only bot commented Nov 28, 2023

repokitteh-read-only bot commented Nov 30, 2023

yanjunxiang-google Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

jbohanon Jan 16, 2024

Choose a reason for hiding this comment

yanjunxiang-google commented Jan 16, 2024

repokitteh-read-only bot commented Jan 16, 2024

jbohanon commented Jan 16, 2024

abeyad commented Jan 16, 2024

tyxia left a comment

Choose a reason for hiding this comment

tyxia commented Jan 17, 2024

linsun commented Jan 19, 2024

jbohanon commented Nov 28, 2023 •

edited

Loading

yanjunxiang-google Jan 16, 2024 •

edited

Loading