-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement CEL doc #31487
improvement CEL doc #31487
Conversation
Signed-off-by: zirain <[email protected]>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
/docs |
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/31487/docs/index.html The docs are (re-)rendered each time the CI |
Thanks, nice catch. Seems you have fixed the docs of access log cel filter, could you also update the cel formatter? Thanks. |
/wait |
Signed-off-by: zirain <[email protected]>
this page is better, and I think another page need improvement. |
Signed-off-by: zirain <[email protected]>
/docs |
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/31487/docs/index.html The docs are (re-)rendered each time the CI |
@wbpcode ptal again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Commit Message: improvement CEL doc
Additional Description: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/formatter/cel/v3/cel.proto#extensions-formatter-cel-v3-cel
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]