Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement CEL doc #31487

Merged
merged 3 commits into from
Dec 22, 2023
Merged

improvement CEL doc #31487

merged 3 commits into from
Dec 22, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Dec 21, 2023

Commit Message: improvement CEL doc
Additional Description: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/formatter/cel/v3/cel.proto#extensions-formatter-cel-v3-cel
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #31487 was opened by zirain.

see: more, trace.

@wbpcode
Copy link
Member

wbpcode commented Dec 22, 2023

/docs

Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/31487/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #31487 (comment) was created by @wbpcode.

see: more, trace.

@wbpcode
Copy link
Member

wbpcode commented Dec 22, 2023

Thanks, nice catch. Seems you have fixed the docs of access log cel filter, could you also update the cel formatter? Thanks.

See https://storage.googleapis.com/envoy-pr/ef3825f/docs/api-v3/extensions/formatter/cel/v3/cel.proto.html#extensions-formatter-cel-v3-cel

@wbpcode
Copy link
Member

wbpcode commented Dec 22, 2023

/wait

Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Contributor Author

zirain commented Dec 22, 2023

https://storage.googleapis.com/envoy-pr/ef3825f/docs/api-v3/extensions/access_loggers/filters/cel/v3/cel.proto.html

this page is better, and I think another page need improvement.

Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Contributor Author

zirain commented Dec 22, 2023

/docs

Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/31487/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #31487 (comment) was created by @zirain.

see: more, trace.

@zirain zirain changed the title improvement CEL formatter doc improvement CEL doc Dec 22, 2023
@zirain
Copy link
Contributor Author

zirain commented Dec 22, 2023

@wbpcode ptal again.

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@wbpcode wbpcode merged commit 55b942a into envoyproxy:main Dec 22, 2023
54 checks passed
@zirain zirain deleted the cel-doc branch December 22, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants