Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Force the dfp_mixed_scheme flag to true in Envoy Mobile #31586

Merged
merged 1 commit into from
Jan 2, 2024

mobile: Force the dfp_mixed_scheme flag to true in Envoy Mobile

16e0506
Select commit
Loading
Failed to load commit list.
Merged

mobile: Force the dfp_mixed_scheme flag to true in Envoy Mobile #31586

mobile: Force the dfp_mixed_scheme flag to true in Envoy Mobile
16e0506
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Core succeeded Jan 2, 2024 in 15m 13s

Mobile/Core (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/Core (pr/31586/main@16e0506)

Check started by

Request (pr/31586/main@16e0506)

abeyad @abeyad 16e0506 #31586 merge main@917d6c9

mobile: Force the dfp_mixed_scheme flag to true in Envoy Mobile

Envoy Mobile always requires dfp_mixed_scheme for the TLS and cleartext DFP clusters. While dfp_mixed_scheme defaults to true, some environments (like within Google), force it to false for the Envoy use case, so we force it back to true here in Envoy Mobile, so we don't break the mobile integration tests.

Once general use of dfp_mixed_scheme is fixed everywhere, we can revert this commit.

Tested by changing dfp_mixed_scheme to FALSE_RUNTIME_GUARD and running the mobile xDS integration tests:

cd mobile
bazelisk test --test_output=streamed --cache_test_results=no //test/common/integration:rtds_integration_test
Environment

Request variables

Key Value
ref ea4306c288a6472aef9946ef166bf759008edf01
sha 16e0506
pr 31586
base-sha 917d6c9
actor abeyad @abeyad
message mobile: Force the dfp_mixed_scheme flag to true in Envoy Mobile...
started 1704218714.554573
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:fd9ec000fdd72d5c5e4e4ef16db4f9103058779e
mobile envoyproxy/envoy-build-ubuntu:mobile-fd9ec000fdd72d5c5e4e4ef16db4f9103058779e
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 29
patch 0
dev true