Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/examples: Assorted cleanups #31588

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Jan 2, 2024

Assorted small docs/example updates/cleanups

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Comment on lines +49 to +53
/* restore margin bottom on aligned images */
.rst-content img.align-center {
margin-bottom: 24px
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems this is additional view change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - a small css fix to give images (that have been aligned) some space at the bottom, consistent with if they had not been aligned

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax merged commit 75dc562 into envoyproxy:main Jan 3, 2024
53 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Jan 3, 2024
phlax added a commit to phlax/envoy that referenced this pull request Jan 3, 2024
phlax added a commit to phlax/envoy that referenced this pull request Jan 3, 2024
phlax added a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
phlax added a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this pull request Apr 3, 2024
Signed-off-by: Ryan Northey <[email protected]>

Signed-off-by: phlax <[email protected]>
Signed-off-by: Sean Killeen <[email protected]>
yxun pushed a commit to yxun/envoy that referenced this pull request Aug 9, 2024
* upstream/release/v1.26: (45 commits)
  repo: Dev 1.26.8 (envoyproxy#32331)
  repo: Release v1.26.7
  Proxy protocol: sanitise non utf8 chars in TLVs
  Fix crashes when proxyproto receives address type not supported by the OS
  Cache RE object in uri template matcher.
  Fix crash when idle and per try timeouts occurs within backoff interval
  Fix crash from AWS NLB healthchecks when proxy protocol is enabled
  ci/release: Ensure windows is built on release
  release/ci: Fix artefact publishing (envoyproxy#31837)
  coverage: lower coverage for source/common/io/ (envoyproxy#32150)
  deps: bump Boost to 1.84.0 (envoyproxy#31566)
  deps/tooling: Bump python (~vulnerable) dependencies
  deps/build: Bump Ubuntu base image -> bb1c41
  build(deps): bump distroless/base-nossl-debian12 from `8c957f0` to `51ab103` in /ci (envoyproxy#32159)
  build(deps): bump distroless/base-nossl-debian12 from `8a0cabc` to `8c957f0` in /ci (envoyproxy#31389)
  deps: Bump `com_github_grpc_grpc` -> 1.49.4
  debs/build: Bump Ubuntu base image -> f2034e7
  docs/examples: Assorted cleanups (envoyproxy#31588)
  deps/go: Bump to resolve CVEs
  golang: fix replace path in go.mod (envoyproxy#31297)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants